Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(511)

Issue 113180043: code review 113180043: cmd/ld: change DWARF encoding for array lengths (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by r
Modified:
10 years, 10 months ago
Reviewers:
rsc, iant
CC:
rsc, iant, golang-codereviews
Visibility:
Public.

Description

cmd/ld: change DWARF encoding for array lengths They can be large, so use a varint encoding rather than only one byte.

Patch Set 1 #

Patch Set 2 : diff -r 65ce0df44258 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/ld/dwarf.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
r
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 10 months ago (2014-07-15 16:17:25 UTC) #1
iant
LGTM
10 years, 10 months ago (2014-07-15 21:06:45 UTC) #2
rsc
LGTM
10 years, 10 months ago (2014-07-15 21:16:46 UTC) #3
rsc
There is a corner case with 0-length arrays that have never been well-described in DWARF. ...
10 years, 10 months ago (2014-07-15 21:17:54 UTC) #4
r
10 years, 10 months ago (2014-07-15 21:18:21 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=acaee74c3fdb ***

cmd/ld: change DWARF encoding for array lengths
They can be large, so use a varint encoding rather than only one byte.

LGTM=iant, rsc
R=rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/113180043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b