Issue 113140043: code review 113140043: cmd/go: skip vcs tests on nacl and android

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 113140043: code review 113140043: cmd/go: skip vcs tests on nacl and android (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by dave

Modified:
10 years, 8 months ago

Reviewers:
gobot, adg

CC:
golang-codereviews, adg

Visibility:
Public.

Description

cmd/go: skip vcs tests on nacl and android Fixes build failures on nacl/* and android/* platforms.

Patch Set 1 #

Patch Set 2 : diff -r 475cdb6f8369 https://code.google.com/p/go #

Patch Set 3 : diff -r 475cdb6f8369 https://code.google.com/p/go #

Patch Set 4 : diff -r 475cdb6f8369 https://code.google.com/p/go #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/cmd/go/vcs_test.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 8 months ago (2014-07-15 04:39:42 UTC) #1

dave_cheney.net

*** Submitted as https://code.google.com/p/go/source/detail?r=9b75c8fa45c1 *** cmd/go: skip vcs tests on nacl and android Fixes build ...

10 years, 8 months ago (2014-07-15 04:46:16 UTC) #3

gobot

This CL appears to have broken the netbsd-amd64-bsiegert builder. See http://build.golang.org/log/d5ce423f61e4b0256e56395026f86ff72a008daa

10 years, 8 months ago (2014-07-15 04:59:27 UTC) #4

dave_cheney.net

10 years, 8 months ago (2014-07-15 05:07:34 UTC) #5

Nope.

# GOMAXPROCS=2 runtime -cpu=1,2,4

--- FAIL: TestFinalizerType-4 (6.06s)
mfinal_test.go:61: finalizer for type func(*int) didn't run
FAIL
FAIL runtime 186.968s
Build complete, duration 12m54.478893862s. Result: error: exit status 1

On Tue, Jul 15, 2014 at 2:59 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the netbsd-amd64-bsiegert builder.
> See http://build.golang.org/log/d5ce423f61e4b0256e56395026f86ff72a008daa
>
> https://codereview.appspot.com/113140043/

Expand All Messages | Collapse All Messages