Issue 11313043: code review 11313043: cmd/gc: tweak interface satisfaction error message

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11313043: code review 11313043: cmd/gc: tweak interface satisfaction error message (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by rsc

Modified:
11 years, 11 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/gc: tweak interface satisfaction error message "M requires pointer receiver" can be misinterpreted to mean that method M should have a pointer receiver but does not. In fact the message means "M has a pointer receiver" (and you don't have a pointer). Fixes issue 5891.

Patch Set 1 #

Patch Set 2 : diff -r 2eed959dd4c7 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 2eed959dd4c7 https://code.google.com/p/go/ #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/cmd/gc/subr.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/cmd/gc/typecheck.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 11 months ago (2013-07-16 00:39:04 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=90456b366cf5 *** cmd/gc: tweak interface satisfaction error message "M requires pointer receiver" ...

11 years, 11 months ago (2013-07-16 00:39:11 UTC) #2

ken3

11 years, 11 months ago (2013-07-19 09:32:19 UTC) #3

Message was sent while issue was closed.

On 2013/07/16 00:39:11, rsc wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=90456b366cf5 ***
> 
> cmd/gc: tweak interface satisfaction error message
> 
> "M requires pointer receiver" can be misinterpreted to
> mean that method M should have a pointer receiver but
> does not. In fact the message means "M has a pointer
> receiver" (and you don't have a pointer).
> 
> Fixes issue 5891.
> 
> R=ken2
> CC=golang-dev
> https://codereview.appspot.com/11313043

lgtm

Expand All Messages | Collapse All Messages