Issue 11303044: Support for testing min and max versions of Guile.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11303044: Support for testing min and max versions of Guile. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by Julien Rioux

Modified:
10 years, 9 months ago

Reviewers:
Graham Percival, dak

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Support for testing min and max versions of Guile. Require 1.8.2 <= x < 2.0.0 where x=Guile version.

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -20 lines)			Patch
	M	aclocal.m4	View		2 chunks	+68 lines, -18 lines	0 comments	Download
	M	configure.ac	View		2 chunks	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dak

https://codereview.appspot.com/11303044/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/11303044/diff/1/configure.ac#newcode125 configure.ac:125: STEPMAKE_GUILE_DEVEL(REQUIRED, 1.8.2, 2.0.0) As far as I know, 1.9 ...

10 years, 9 months ago (2013-07-22 14:03:31 UTC) #2

Julien Rioux

10 years, 9 months ago (2013-07-22 18:09:53 UTC) #3

On Mon, Jul 22, 2013 at 1:18 PM, Graham Percival
<graham@percival-music.ca>wrote:

> On Mon, Jul 22, 2013 at 02:03:31PM +0000, dak@gnu.org wrote:
> > As far as I know, 1.9 is the development series culminating in the
> > stable 2.0, so while 1.9 is not all too likely to be installed on
> > current systems, allowing/preferring it over 1.8 is not going to be
> > helpful.  I think the cutoff point should be at 1.9.
>
> Good point.
>
>
I'll make sure to make the change before committing.

> > Do we have an override option for those people who actually want to
> > develop towards 2.0 or are they supposed to edit the autoconf files?
>
> Don't we have a separate branch for guile-2.0?  If not, we should,
> and that branch can change the numbers to "guile 2.0 or higher".
> (or 2.x if we rely on any more recent guile features or bugfixe)
>

One overrides these auto settings in the usual way, setting
GUILE=/path/to/guile etc on the command line. And as you have seen, once we
are ready for guile 2, it's a one-line change in configure.ac

>> Should we document this somewhere?

I think the commit message, pointing to the relevant tracker issue and code
review, should be sufficient.

Cheers,
Julien

Expand All Messages | Collapse All Messages