Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2208)

Issue 11297043: code review 11297043: go.crypto/ssh/terminal: support Go 1.0. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by agl1
Modified:
7 years, 7 months ago
Reviewers:
rsc
CC:
golang-dev, rsc
Visibility:
Public.

Description

go.crypto/ssh/terminal: support Go 1.0. For those still stuck on Go 1.0.

Patch Set 1 #

Patch Set 2 : diff -r 81eec9b5ce2d https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r 81eec9b5ce2d https://code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r 81eec9b5ce2d https://code.google.com/p/go.crypto/ #

Patch Set 5 : diff -r 81eec9b5ce2d https://code.google.com/p/go.crypto/ #

Patch Set 6 : diff -r 81eec9b5ce2d https://code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ssh/terminal/terminal.go View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/
7 years, 7 months ago (2013-07-15 20:09:24 UTC) #1
rsc
LGTM
7 years, 7 months ago (2013-07-15 20:59:31 UTC) #2
rsc
Please put a comment panic("unreachable") // for Go 1.0 so no one removes it later.
7 years, 7 months ago (2013-07-15 20:59:54 UTC) #3
agl1
7 years, 7 months ago (2013-07-15 22:01:45 UTC) #4
*** Submitted as
https://code.google.com/p/go/source/detail?r=3b780a7120c9&repo=crypto ***

go.crypto/ssh/terminal: support Go 1.0.

For those still stuck on Go 1.0.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/11297043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b