Issue 112970044: code review 112970044: go/*: permit "for range x"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 112970044: code review 112970044: go/*: permit "for range x" (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by gri

Modified:
9 years, 9 months ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

go/*: permit "for range x"

Patch Set 1 #

Patch Set 2 : diff -r 877f66c3a650 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6866fbf95095 https://code.google.com/p/go/ #

Patch Set 4 : diff -r fcb7e7aa1740 https://code.google.com/p/go/ #

Patch Set 5 : diff -r fcb7e7aa1740 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 1739cf8be3ea https://code.google.com/p/go/ #

Patch Set 7 : diff -r 1739cf8be3ea https://code.google.com/p/go/ #

Patch Set 8 : diff -r 1739cf8be3ea https://code.google.com/p/go/ #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -14 lines)			Patch
M	src/pkg/go/ast/ast.go	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/go/parser/parser.go	View	1 2 3 4 5 6	2 chunks	+15 lines, -4 lines	0 comments	Download
M	src/pkg/go/parser/short_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/go/printer/nodes.go	View	1 2 3 4	1 chunk	+10 lines, -7 lines	0 comments	Download
M	src/pkg/go/printer/testdata/statements.golden	View	1 2 3 4 5	2 chunks	+9 lines, -0 lines	0 comments	Download
M	src/pkg/go/printer/testdata/statements.input	View	1 2 3 4 5	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Yes, this was just a quick sanity check. Printer stuff coming shortly. - gri On ...

9 years, 9 months ago (2014-07-14 22:28:27 UTC) #2

gri

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

9 years, 9 months ago (2014-07-14 23:11:22 UTC) #3

gri

9 years, 9 months ago (2014-07-14 23:17:20 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=29e283742de1 ***

go/*: permit "for range x"

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/112970044

Expand All Messages | Collapse All Messages