Removes cloned drag icon

Removes cloned drag icon

In order to fix the issue where a user could scroll
the page by dragging an icon off of it, this branch
removes the cloned drag icon and uses the actual
icon already in the DOM.

https://code.launchpad.net/~hatch/juju-gui/dd-fix-1200412/+merge/174783

(do not edit description out of merge proposal)

[jeff.pihach, 2013-07-15 14:58:15]

Please take a look.

[benjamin.saller, 2013-07-15 15:07:15]

LGTM

with trivials, didn't QA though. Thanks

https://codereview.appspot.com/11283043/diff/1/app/views/ghost-inspector.js
File app/views/ghost-inspector.js (right):

https://codereview.appspot.com/11283043/diff/1/app/views/ghost-inspector.js#n...
app/views/ghost-inspector.js:85: /**
The horror!

https://codereview.appspot.com/11283043/diff/1/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/11283043/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:424: ghostAttributes.icon =
evt.dataTransfer.getData('iconSrc');
Is there a reason to treat data as key/value api vs using a single encoded
field. The API specifies that it should be 'type' such as text or url.

https://codereview.appspot.com/11283043/diff/1/app/widgets/charm-token.js
File app/widgets/charm-token.js (right):

https://codereview.appspot.com/11283043/diff/1/app/widgets/charm-token.js#new...
app/widgets/charm-token.js:100: dataTransfer.setData('dataType',
'charm-token-drag-and-drop');
Same comment as before, might want a single get/set of the data.

https://codereview.appspot.com/11283043/diff/1/test/test_charm_token_drag_and...
File test/test_charm_token_drag_and_drop.js (right):

https://codereview.appspot.com/11283043/diff/1/test/test_charm_token_drag_and...
test/test_charm_token_drag_and_drop.js:186: //assert.deepEqual(dragDataSet, []);
remove

https://codereview.appspot.com/11283043/diff/1/test/test_service_module.js
File test/test_service_module.js (right):

https://codereview.appspot.com/11283043/diff/1/test/test_service_module.js#ne...
test/test_service_module.js:378: .append('<img src="' + src + '" />');
append('<img>').set('src', src) might be better

https://codereview.appspot.com/11283043/diff/1/test/test_service_module.js#ne...
test/test_service_module.js:389: return src;
You could always just return the same JSON blob if the change I suggested was
made making this a tad simpler.

[matthew.scott, 2013-07-15 15:15:59]

LGTM with default charm icon bug fixed.

https://codereview.appspot.com/11283043/diff/1/app/views/ghost-inspector.js
File app/views/ghost-inspector.js (right):

https://codereview.appspot.com/11283043/diff/1/app/views/ghost-inspector.js#n...
app/views/ghost-inspector.js:85: /**
Huh.  Okay :)

[jeff.pihach, 2013-07-15 18:06:44]

Thanks for the reviews.

https://codereview.appspot.com/11283043/diff/1/app/views/ghost-inspector.js
File app/views/ghost-inspector.js (right):

https://codereview.appspot.com/11283043/diff/1/app/views/ghost-inspector.js#n...
app/views/ghost-inspector.js:85: /**
The previous comment caused IE10 to error out

https://codereview.appspot.com/11283043/diff/1/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/11283043/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:424: ghostAttributes.icon =
evt.dataTransfer.getData('iconSrc');
Good idea, I'll give that a try.

https://codereview.appspot.com/11283043/diff/1/app/widgets/charm-token.js
File app/widgets/charm-token.js (right):

https://codereview.appspot.com/11283043/diff/1/app/widgets/charm-token.js#new...
app/widgets/charm-token.js:100: dataTransfer.setData('dataType',
'charm-token-drag-and-drop');
On 2013/07/15 15:07:15, benjamin.saller wrote:
> Same comment as before, might want a single get/set of the data.

Done.

https://codereview.appspot.com/11283043/diff/1/test/test_charm_token_drag_and...
File test/test_charm_token_drag_and_drop.js (right):

https://codereview.appspot.com/11283043/diff/1/test/test_charm_token_drag_and...
test/test_charm_token_drag_and_drop.js:186: //assert.deepEqual(dragDataSet, []);
On 2013/07/15 15:07:15, benjamin.saller wrote:
> remove

Done.

https://codereview.appspot.com/11283043/diff/1/test/test_service_module.js
File test/test_service_module.js (right):

https://codereview.appspot.com/11283043/diff/1/test/test_service_module.js#ne...
test/test_service_module.js:378: .append('<img src="' + src + '" />');
On 2013/07/15 15:07:15, benjamin.saller wrote:
> append('<img>').set('src', src) might be better

Done.

https://codereview.appspot.com/11283043/diff/1/test/test_service_module.js#ne...
test/test_service_module.js:389: return src;
On 2013/07/15 15:07:15, benjamin.saller wrote:
> You could always just return the same JSON blob if the change I suggested was
> made making this a tad simpler.

Done.

[jeff.pihach, 2013-07-15 20:13:55]

Please take a look.

[jeff.pihach, 2013-07-15 20:27:07]

*** Submitted:

Removes cloned drag icon

In order to fix the issue where a user could scroll
the page by dragging an icon off of it, this branch
removes the cloned drag icon and uses the actual
icon already in the DOM.

R=benjamin.saller, matthew.scott
CC=
https://codereview.appspot.com/11283043