code review 11280043: runtime: minor test cleanup

runtime: minor test cleanup

[dvyukov, 2013-07-15 14:01:14]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[khr1, 2013-07-15 20:01:57]

LGTM.


On Mon, Jul 15, 2013 at 7:01 AM, <dvyukov@google.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
>
https://dvyukov%40google.com@**code.google.com/p/go/<http://40google.com@code...
>
>
> Description:
> runtime: minor test cleanup
>
> Please review this at
https://codereview.appspot.**com/11280043/<https://codereview.appspot.com/112...
>
> Affected files:
>   M src/pkg/runtime/proc_test.go
>
>
> Index: src/pkg/runtime/proc_test.go
> ==============================**==============================**=======
> --- a/src/pkg/runtime/proc_test.go
> +++ b/src/pkg/runtime/proc_test.go
> @@ -227,7 +227,7 @@
>         stop := make(chan int)
>         go big(stop)
>         for i := 0; i < 3; i++ {
> -               time.Sleep(1 * time.Microsecond) // let big start running
> +               time.Sleep(10 * time.Microsecond) // let big start running
>                 runtime.GC()
>         }
>         close(stop)
> @@ -237,7 +237,7 @@
>         n := 0
>         for {
>                 // delay so that gc is sure to have asked for a preemption
> -               for i := int64(0); i < 1e9; i++ {
> +               for i := 0; i < 1e9; i++ {
>                         n++
>                 }
>
> @@ -286,9 +286,6 @@
>         }
>  }
>
> -func poll() {
> -}
> -
>  func TestSchedLocalQueue(t *testing.T) {
>         runtime.TestSchedLocalQueue1()
>  }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[rsc, 2013-07-15 20:41:55]

LGTM

[dvyukov, 2013-07-15 21:03:35]

*** Submitted as https://code.google.com/p/go/source/detail?r=aed85a24be49 ***

runtime: minor test cleanup

R=golang-dev, khr, rsc
CC=golang-dev
https://codereview.appspot.com/11280043