Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 112780044: code review 112780044: ogle/debug/dwarf: use buf.string to read a string (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by r
Modified:
7 years, 4 months ago
Reviewers:
nigeltao
CC:
nigeltao
Visibility:
Public.

Description

ogle/debug/dwarf: use buf.string to read a string Removes some duplicated functionality; cleans up a TODO. No functional change.

Patch Set 1 #

Patch Set 2 : diff -r d4c9dc09c25f https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M debug/dwarf/line.go View 2 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 3
r
Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 4 months ago (2014-07-08 16:42:05 UTC) #1
nigeltao
LGTM.
7 years, 4 months ago (2014-07-09 02:45:21 UTC) #2
r
7 years, 4 months ago (2014-07-09 17:47:37 UTC) #3
*** Submitted as https://code.google.com/p/ogle/source/detail?r=5ff4bcb86e53 ***

ogle/debug/dwarf: use buf.string to read a string
Removes some duplicated functionality; cleans up a TODO.
No functional change.

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/112780044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b