Issue 112780044: code review 112780044: ogle/debug/dwarf: use buf.string to read a string

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 112780044: code review 112780044: ogle/debug/dwarf: use buf.string to read a string (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by r

Modified:
11 years, 3 months ago

Reviewers:
nigeltao

CC:
nigeltao

Visibility:
Public.

Description

ogle/debug/dwarf: use buf.string to read a string Removes some duplicated functionality; cleans up a TODO. No functional change.

Patch Set 1 #

Patch Set 2 : diff -r d4c9dc09c25f https://code.google.com/p/ogle #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -15 lines)			Patch
	M	debug/dwarf/line.go	View		2 chunks	+2 lines, -15 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle

11 years, 3 months ago (2014-07-08 16:42:05 UTC) #1

11 years, 3 months ago (2014-07-09 17:47:37 UTC) #3

*** Submitted as https://code.google.com/p/ogle/source/detail?r=5ff4bcb86e53 ***

ogle/debug/dwarf: use buf.string to read a string
Removes some duplicated functionality; cleans up a TODO.
No functional change.

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/112780044

Expand All Messages | Collapse All Messages