Issue 112770045: code review 112770045: compiler: Fix C-style comment parsing.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 112770045: code review 112770045: compiler: Fix C-style comment parsing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by iant

Modified:
9 years, 9 months ago

Reviewers:

CC:
iant, gofrontend-dev_googlegroups.com

Visibility:
Public.

Description

compiler: Fix C-style comment parsing. The compiler was incorrectly seeing /*/ as a complete C-style comment. Fixes issue 35.

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	go/lex.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

iant

Hello iant (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://gofrontend.googlecode.com/hg/

9 years, 9 months ago (2014-07-08 20:42:20 UTC) #1

iant

9 years, 9 months ago (2014-07-08 20:42:25 UTC) #2

*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=d53fa58639b9 ***

compiler: Fix C-style comment parsing.

The compiler was incorrectly seeing /*/ as a complete C-style
comment.

Fixes issue 35.

R=iant
CC=gofrontend-dev
https://codereview.appspot.com/112770045

Expand All Messages | Collapse All Messages