Issue 11276043: Update the viewmode controls to always update

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11276043: Update the viewmode controls to always update

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by rharding

Modified:
10 years, 9 months ago

Reviewers:
mp+174750, j.c.sackett, gary.poster

Visibility:
Public.

Description

Update the viewmode controls to always update - Add a test that it's honoring the ATTR https://code.launchpad.net/~rharding/juju-gui/update-state-icons/+merge/174750 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Update the viewmode controls to always update #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -7 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/views/view.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	app/widgets/viewmode-controls.js	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	test/test_viewmode_controls_widget.js	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rharding

10 years, 9 months ago (2013-07-15 14:49:35 UTC) #4

*** Submitted:

Update the viewmode controls to always update

- Add a test that it's honoring the ATTR

R=j.c.sackett, gary.poster
CC=
https://codereview.appspot.com/11276043

Expand All Messages | Collapse All Messages