code review 112720043: syscall: use the nsec system call instead of /dev/binti...

syscall: use the nsec system call instead of /dev/bintime on Plan 9

Also remove arch-specific Go files in the Plan 9 syscall package

[aram, 2014-07-07 13:36:50]

Hello 0intro (cc: ality, dfc, golang-codereviews@googlegroups.com, jas,
mischief@9.offblast.org, rsc),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2014-07-07 14:38:47]

https://codereview.appspot.com/112720043/diff/40001/src/pkg/syscall/zsysnum_p...
File src/pkg/syscall/zsysnum_plan9_amd64.go (left):

https://codereview.appspot.com/112720043/diff/40001/src/pkg/syscall/zsysnum_p...
src/pkg/syscall/zsysnum_plan9_amd64.go:47: SYS_NANOTIME   = 60
you can't delete this symbol, it's part of the syscall API

[aram, 2014-07-07 14:41:11]

https://codereview.appspot.com/112720043/diff/40001/src/pkg/syscall/zsysnum_p...
File src/pkg/syscall/zsysnum_plan9_amd64.go (left):

https://codereview.appspot.com/112720043/diff/40001/src/pkg/syscall/zsysnum_p...
src/pkg/syscall/zsysnum_plan9_amd64.go:47: SYS_NANOTIME   = 60
On 2014/07/07 14:38:47, dfc wrote:
> you can't delete this symbol, it's part of the syscall API

Well, sorry, this system call simply doesn't exist. Considering that the
plan9/amd64 port never worked at all, so nobody could have ever used this
symbol, I think it's fine to remove it (and fix the api tool if needed).

[0intro, 2014-07-07 15:10:28]

> you can't delete this symbol, it's part of the syscall API

The SYS_NANOTIME (number 60) syscall was an experiment in
the NxM operating system (fork of NIX, experimental Plan 9
amd64 port). NxM is now defunct.

It was later (in may 2014) integrated into Plan 9 (both 386
and amd64), and was renamed SYS_NSEC with number 53.

[0intro, 2014-07-07 22:11:30]

LGTM

[aram, 2014-07-08 05:43:41]

> you can't delete this symbol, it's part of the syscall API

Also it seems we don't run the api tool for Plan 9 at all.

[ality, 2014-07-08 06:30:52]

dave@cheney.net once said:
> 
>
https://codereview.appspot.com/112720043/diff/40001/src/pkg/syscall/zsysnum_p...
> File src/pkg/syscall/zsysnum_plan9_amd64.go (left):
> 
>
https://codereview.appspot.com/112720043/diff/40001/src/pkg/syscall/zsysnum_p...
> src/pkg/syscall/zsysnum_plan9_amd64.go:47: SYS_NANOTIME   = 60
> you can't delete this symbol, it's part of the syscall API

There is no API guarantee for Plan 9 yet:

    % cd $GOROOT/api
    % grep '\(plan9' *
    %

We can change anything in the syscall package and I plan
on revising my old CLs that remove large chunks of it.

  Anthony

[aram, 2014-07-08 06:32:39]

On Tue, Jul 8, 2014 at 8:30 AM, Anthony Martin <ality@pbrane.org> wrote:
> We can change anything in the syscall package and I plan
> on revising my old CLs that remove large chunks of it.

Good idea.

-- 
Aram Hăvărneanu

[aram, 2014-07-09 10:34:17]

*** Submitted as https://code.google.com/p/go/source/detail?r=6d7628da48cc ***

syscall: use the nsec system call instead of /dev/bintime on Plan 9

Also remove arch-specific Go files in the Plan 9 syscall package

LGTM=0intro
R=0intro, dave
CC=ality, golang-codereviews, jas, mischief, rsc
https://codereview.appspot.com/112720043