Update the home link to not always show.

Update the home link to not always show.

- Only show when you're not seeing editorial content
- Make sure we show/hide it on init and on subsequent changes to the subapp
state.

https://code.launchpad.net/~rharding/juju-gui/smart-home/+merge/174794

(do not edit description out of merge proposal)

[rharding, 2013-07-15 17:36:39]

Please take a look.

[j.c.sackett, 2013-07-15 17:49:58]

LGTM, with one request.

https://codereview.appspot.com/11271045/diff/3001/app/subapps/browser/browser.js
File app/subapps/browser/browser.js (right):

https://codereview.appspot.com/11271045/diff/3001/app/subapps/browser/browser...
app/subapps/browser/browser.js:694: );
Can you update the jujucharms code as well? That uses showview and was following
the same broken pattern.

We're not (currently) doing anything with that reference, but I would hate one
of us to trip over it later and forget that this needs to be done.

[gary.poster, 2013-07-15 17:51:37]

LGTM!  Thank you!

Gary

https://codereview.appspot.com/11271045/diff/3001/app/subapps/browser/views/v...
File app/subapps/browser/views/view.js (right):

https://codereview.appspot.com/11271045/diff/3001/app/subapps/browser/views/v...
app/subapps/browser/views/view.js:115: this.search.showHome();
Please add some comments to explain why we need both this and the class (thanks
for the explanation).

[rharding, 2013-07-15 18:08:41]

*** Submitted:

Update the home link to not always show.

- Only show when you're not seeing editorial content
- Make sure we show/hide it on init and on subsequent changes to the subapp
state.

R=j.c.sackett, gary.poster
CC=
https://codereview.appspot.com/11271045