Issue 1127043: fixed bugs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1127043: fixed bugs

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by calidion

Modified:
7 years, 4 months ago

Reviewers:
xan, weiliu, baiming, leio.chen, lychen, qiaojian, quguangfan, heian911

CC:
xinxing_google.com, lishuangfeng_gmail.com

Base URL:
http://scheduleeditor.googlecode.com/svn/trunk/python/

Visibility:
Public.

Patch Set 2 : update #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -118 lines)			Patch
	M	gtfsscheduleviewer/files/transit_editor.js	View	1	8 chunks	+35 lines, -118 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

baiming

LGTM http://codereview.appspot.com/1127043/diff/1/2 File gtfsscheduleviewer/files/transit_editor.js (right): http://codereview.appspot.com/1127043/diff/1/2#newcode1683 gtfsscheduleviewer/files/transit_editor.js:1683: if (!confirm('Generate will clear changes you made previously, ...

13 years, 11 months ago (2010-05-13 01:41:46 UTC) #2

calidion

13 years, 11 months ago (2010-05-13 02:04:37 UTC) #3

updated to rev 81

2010/5/13 <baiming@google.com>

> LGTM
>
>
> http://codereview.appspot.com/1127043/diff/1/2
> File gtfsscheduleviewer/files/transit_editor.js (right):
>
> http://codereview.appspot.com/1127043/diff/1/2#newcode1683
> gtfsscheduleviewer/files/transit_editor.js:1683: if (!confirm('Generate
> will clear changes you made previously, Sure to continue?')) {
> Line exceeds 80 char limit.
>
>
> http://codereview.appspot.com/1127043/show
>

Expand All Messages | Collapse All Messages