Issue 112520043: code review 112520043: cmd/gc: don't mark select descriptor as EscNone

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 112520043: code review 112520043: cmd/gc: don't mark select descriptor as EscNone

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by bpowers

Modified:
9 years, 9 months ago

Reviewers:
dvyukov

CC:
golang-codereviews, dave_cheney.net, dvyukov

Visibility:
Public.

Description

cmd/gc: don't mark select descriptor as EscNone selv is created with temp() which calls tempname, which marks the new n with EscNever, so there is no need to explicitly set EscNone on the select descriptor. Fixes issue 8396.

Patch Set 1 #

Patch Set 2 : diff -r bbddc25284e9 https://code.google.com/p/go #

Patch Set 3 : diff -r 82cbf874e066 https://code.google.com/p/go #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/cmd/gc/select.c	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dave_cheney.net

Please hg mail 112520043 to start the review process.

9 years, 9 months ago (2014-07-21 09:37:27 UTC) #1

bpowers

Hello golang-codereviews@googlegroups.com, dave@cheney.net (cc: dvyukov@google.com, golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 9 months ago (2014-07-21 12:54:21 UTC) #2

dvyukov

9 years, 9 months ago (2014-07-25 07:23:08 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=b6a42b0aeef6 ***

cmd/gc: don't mark select descriptor as EscNone

selv is created with temp() which calls tempname, which marks
the new n with EscNever, so there is no need to explicitly set
EscNone on the select descriptor.

Fixes issue 8396.

LGTM=dvyukov
R=golang-codereviews, dave, dvyukov
CC=golang-codereviews
https://codereview.appspot.com/112520043

Committer: Dmitriy Vyukov <dvyukov@google.com>

Expand All Messages | Collapse All Messages