Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(523)

Issue 112520043: code review 112520043: cmd/gc: don't mark select descriptor as EscNone

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 4 months ago by bpowers
Modified:
8 years, 4 months ago
Reviewers:
dvyukov
CC:
golang-codereviews, dfc, dvyukov
Visibility:
Public.

Description

cmd/gc: don't mark select descriptor as EscNone selv is created with temp() which calls tempname, which marks the new n with EscNever, so there is no need to explicitly set EscNone on the select descriptor. Fixes issue 8396.

Patch Set 1 #

Patch Set 2 : diff -r bbddc25284e9 https://code.google.com/p/go #

Patch Set 3 : diff -r 82cbf874e066 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/cmd/gc/select.c View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5
dfc
Please hg mail 112520043 to start the review process.
8 years, 4 months ago (2014-07-21 09:37:27 UTC) #1
bpowers
Hello golang-codereviews@googlegroups.com, dave@cheney.net (cc: dvyukov@google.com, golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
8 years, 4 months ago (2014-07-21 12:54:21 UTC) #2
bpowers
ping. any thoughts on this?
8 years, 4 months ago (2014-07-25 02:47:50 UTC) #3
dvyukov
LGTM
8 years, 4 months ago (2014-07-25 07:06:56 UTC) #4
dvyukov
8 years, 4 months ago (2014-07-25 07:23:08 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=b6a42b0aeef6 ***

cmd/gc: don't mark select descriptor as EscNone

selv is created with temp() which calls tempname, which marks
the new n with EscNever, so there is no need to explicitly set
EscNone on the select descriptor.

Fixes issue 8396.

LGTM=dvyukov
R=golang-codereviews, dave, dvyukov
CC=golang-codereviews
https://codereview.appspot.com/112520043

Committer: Dmitriy Vyukov <dvyukov@google.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b