code review 112490043: test/run: always set goos and goarch

test/run: always set goos and goarch

Following CL 68150047, the goos and goarch
variables are not currently set when the GOOS
and GOARCH environment variables are not set.

This made the content of the build tag to be
ignored in this case.

This CL sets goos and goarch to runtime.GOOS
and runtime.GOARCH when the GOOS and GOARCH
environments variables are not set.

[0intro, 2014-07-20 10:54:54]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[0intro, 2014-07-20 10:56:30]

Obviously, go fmt hasn't been ran on test/run.go for
a long time. We should probably run fmt on test/run.go
in a following CL.

[aram, 2014-07-20 11:06:39]

LGTM

[0intro, 2014-07-20 15:28:18]

+cc rsc

[gobot, 2014-07-21 10:31:52]

R=rsc@golang.org (assigned by dave@cheney.net)

[dave_cheney.net, 2014-07-21 10:37:36]

one minor comment

https://codereview.appspot.com/112490043/diff/40001/test/run.go
File test/run.go (right):

https://codereview.appspot.com/112490043/diff/40001/test/run.go#newcode77
test/run.go:77: }
Please add something like

func getenv(name, def string) string 

to take care of these two, and also the two around line 482

[0intro, 2014-07-21 12:33:03]

PTAL

I haven't changed the two around line 482, since
their purpose is just to set the environments
variables if they were not already.

I think it would be odd to write something like:

os.Setenv("GOOS", getenv("GOOS", runtime.GOOS))

https://codereview.appspot.com/112490043/diff/40001/test/run.go
File test/run.go (right):

https://codereview.appspot.com/112490043/diff/40001/test/run.go#newcode77
test/run.go:77: }
On 2014/07/21 10:37:36, dfc wrote:
> Please add something like
> 
> func getenv(name, def string) string 
> 
> to take care of these two, and also the two around line 482

Done.

[0intro, 2014-07-24 11:47:33]

Ping.

[bradfitz, 2014-07-24 15:55:01]

LGTM



On Thu, Jul 24, 2014 at 4:47 AM, <0intro@gmail.com> wrote:

> Ping.
>
>
> https://codereview.appspot.com/112490043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[0intro, 2014-07-24 21:19:02]

*** Submitted as https://code.google.com/p/go/source/detail?r=2a40ee658066 ***

test/run: always set goos and goarch

Following CL 68150047, the goos and goarch
variables are not currently set when the GOOS
and GOARCH environment variables are not set.

This made the content of the build tag to be
ignored in this case.

This CL sets goos and goarch to runtime.GOOS
and runtime.GOARCH when the GOOS and GOARCH
environments variables are not set.

LGTM=aram, bradfitz
R=golang-codereviews, aram, gobot, rsc, dave, bradfitz
CC=golang-codereviews, rsc
https://codereview.appspot.com/112490043