code review 112440043: runtime: make go vet happy

runtime: make go vet happy

CL 117950044 updates vet to fix LEA* issue.

[khr, 2014-07-18 19:33:01]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://khr%40golang.org@code.google.com/p/go/

[bradfitz, 2014-07-18 19:34:24]

LGTM
 On Jul 18, 2014 2:33 PM, <khr@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://khr%40golang.org@code.google.com/p/go/
>
>
> Description:
> runtime: make go vet happy
>
> CL 117950044 updates vet for nacl and fixes LEA* issue.
>
> Please review this at https://codereview.appspot.com/112440043/
>
> Affected files (+3, -3 lines):
>   M src/pkg/runtime/asm_amd64.s
>   M src/pkg/runtime/asm_amd64p32.s
>
>
> Index: src/pkg/runtime/asm_amd64.s
> ===================================================================
> --- a/src/pkg/runtime/asm_amd64.s
> +++ b/src/pkg/runtime/asm_amd64.s
> @@ -2276,7 +2276,7 @@
>         MOVQ    size+16(FP), DX
>         MOVQ    seed+24(FP), DI
>         MOVQ    DI, ret+32(FP)
> -       LEAQ    ret+32(FP), SI  // TODO: go vet complains here: "invalid
> LEAQ of ret+32(FP); bool is 1-byte value"
> +       LEAQ    ret+32(FP), SI
>         MOVQ    SI, 0(SP)
>         MOVQ    DX, 8(SP)
>         MOVQ    CX, 16(SP)
> Index: src/pkg/runtime/asm_amd64p32.s
> ===================================================================
> --- a/src/pkg/runtime/asm_amd64p32.s
> +++ b/src/pkg/runtime/asm_amd64p32.s
> @@ -672,10 +672,10 @@
>         MOVL    -8(AX),AX               // get calling pc
>         RET
>
> -TEXT runtime·gogetcallerpc(SB),NOSPLIT,$0-8
> +TEXT runtime·gogetcallerpc(SB),NOSPLIT,$0-12
>         MOVL    p+0(FP),AX              // addr of first arg
>         MOVL    -8(AX),AX               // get calling pc
> -       MOVL    AX, ret+4(FP)
> +       MOVL    AX, ret+8(FP)
>         RET
>
>  TEXT runtime·setcallerpc(SB),NOSPLIT,$0-16
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[khr, 2014-07-22 04:35:52]

*** Submitted as https://code.google.com/p/go/source/detail?r=da790858e12c ***

runtime: make go vet happy

CL 117950044 updates vet to fix LEA* issue.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/112440043