Issue 112420043: code review 112420043: A+C: add Xia Bin (individual CLA)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 112420043: code review 112420043: A+C: add Xia Bin (individual CLA) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by rsc

Modified:
10 years, 10 months ago

Reviewers:
gobot, minux

CC:
iant, minux, golang-codereviews

Visibility:
Public.

A+C: add Xia Bin (individual CLA) This CLA replaces the one for 'snyh'. Verified by hand.

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	AUTHORS	View	1	2 chunks	+1 line, -1 line	0 comments	Download
	M	CONTRIBUTORS	View	1	2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 4

rsc

Hello iant, minux (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 10 months ago (2014-07-18 01:46:07 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=c5aaab784278 *** A+C: add Xia Bin (individual CLA) This CLA replaces the ...

10 years, 10 months ago (2014-07-18 16:04:46 UTC) #3

gobot

10 years, 10 months ago (2014-07-18 16:17:27 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/23f277cfbdbdf016678f338d0207b386368cde36