Issue 11241043: Indexing subscriptions

Issue 11241043: Indexing subscriptions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by ana.balica

Modified:
10 years, 10 months ago

Reviewers:
thomas.j.waldmann, waldi

Visibility:
Public.

More Reviews

Patch Set 2 : Change definition of backend_subscriptions_to_index() function #

Patch Set 3 : Test indexing subscribers #

Total comments: 3

Patch Set 4 : Back to (el1, el2, ) style #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -1 line)			Patch
	M	MoinMoin/storage/middleware/_tests/test_indexing.py	View	1 2	2 chunks	+16 lines, -1 line	0 comments	Download
	M	MoinMoin/storage/middleware/indexing.py	View	1 2 3	3 chunks	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

ana.balica

https://codereview.appspot.com/11241043/diff/1/MoinMoin/storage/middleware/indexing.py File MoinMoin/storage/middleware/indexing.py (right): https://codereview.appspot.com/11241043/diff/1/MoinMoin/storage/middleware/indexing.py#newcode141 MoinMoin/storage/middleware/indexing.py:141: doc = backend_subscriptions_to_index(doc, meta[SUBSCRIPTIONS]) All the constant declarations can ...

10 years, 10 months ago (2013-07-13 23:54:16 UTC) #1

Thomas.J.Waldmann

https://codereview.appspot.com/11241043/diff/1/MoinMoin/storage/middleware/indexing.py File MoinMoin/storage/middleware/indexing.py (right): https://codereview.appspot.com/11241043/diff/1/MoinMoin/storage/middleware/indexing.py#newcode167 MoinMoin/storage/middleware/indexing.py:167: elif keyword in [NAMERE, NAMEPREFIX, ]: look if you ...

10 years, 10 months ago (2013-07-14 08:24:37 UTC) #2

ana.balica

https://codereview.appspot.com/11241043/diff/1/MoinMoin/storage/middleware/indexing.py File MoinMoin/storage/middleware/indexing.py (right): https://codereview.appspot.com/11241043/diff/1/MoinMoin/storage/middleware/indexing.py#newcode167 MoinMoin/storage/middleware/indexing.py:167: elif keyword in [NAMERE, NAMEPREFIX, ]: not anywhere else.

10 years, 10 months ago (2013-07-14 08:37:50 UTC) #3

Thomas.J.Waldmann

https://codereview.appspot.com/11241043/diff/8001/MoinMoin/storage/middleware/indexing.py File MoinMoin/storage/middleware/indexing.py (right): https://codereview.appspot.com/11241043/diff/8001/MoinMoin/storage/middleware/indexing.py#newcode165 MoinMoin/storage/middleware/indexing.py:165: if keyword in (ITEMID, NAME, TAGS): trailing comma + ...

10 years, 10 months ago (2013-07-16 16:28:12 UTC) #5

ana.balica

10 years, 10 months ago (2013-07-17 12:08:45 UTC) #6

The commit is pushed and can be found here -
https://bitbucket.org/ana-balica/moin-2.0/commits/c2fe14359d78390391fdec25308...

Expand All Messages | Collapse All Messages