Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(308)

Issue 11238044: Add ANGLE_color_buffer_float and EXT_color_buffer_half_float extension support in ANGLE

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by jun.a.jiang
Modified:
10 years, 7 months ago
Reviewers:
kbr1, dgkoch1, apatrick1, shannon.woods, Zhenyao Mo, Shannon Woods
CC:
angleproject-review_googlegroups.com, John Bauman
Base URL:
https://code.google.com/p/angleproject/@master
Visibility:
Public.

Description

Add ANGLE_color_buffer_float and EXT_color_buffer_half_float extension support in ANGLE BUG=chromium:258371

Patch Set 1 #

Patch Set 2 : Refine some descriptions #

Patch Set 3 : Add some check on Framebuffer completeness check #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+399 lines, -11 lines) Patch
A extensions/ANGLE_color_buffer_float.txt View 1 1 chunk +258 lines, -0 lines 1 comment Download
M src/libGLESv2/Context.cpp View 2 chunks +30 lines, -0 lines 0 comments Download
M src/libGLESv2/Framebuffer.cpp View 1 2 3 chunks +10 lines, -5 lines 0 comments Download
M src/libGLESv2/libGLESv2.cpp View 7 chunks +63 lines, -4 lines 0 comments Download
M src/libGLESv2/renderer/Renderer11.cpp View 1 2 chunks +14 lines, -2 lines 0 comments Download
M src/libGLESv2/renderer/Renderer9.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/libGLESv2/renderer/renderer11_utils.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/libGLESv2/renderer/renderer9_utils.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/libGLESv2/utilities.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6
jun.a.jiang
Thanks for Shannon's help and I can upload patch for review now although I had ...
10 years, 10 months ago (2013-07-14 05:11:48 UTC) #1
kbr1
https://codereview.appspot.com/11238044/diff/13001/extensions/ANGLE_color_buffer_float.txt File extensions/ANGLE_color_buffer_float.txt (right): https://codereview.appspot.com/11238044/diff/13001/extensions/ANGLE_color_buffer_float.txt#newcode11 extensions/ANGLE_color_buffer_float.txt:11: Kenneth Russell, Google Jun, I think you should add ...
10 years, 10 months ago (2013-07-15 20:25:27 UTC) #2
kbr1
+jbauman as FYI and in case he can help with the review
10 years, 10 months ago (2013-07-15 20:26:11 UTC) #3
jun.a.jiang
On 2013/07/15 20:25:27, kbr1 wrote: > https://codereview.appspot.com/11238044/diff/13001/extensions/ANGLE_color_buffer_float.txt > File extensions/ANGLE_color_buffer_float.txt (right): > > https://codereview.appspot.com/11238044/diff/13001/extensions/ANGLE_color_buffer_float.txt#newcode11 > ...
10 years, 10 months ago (2013-07-16 01:39:36 UTC) #4
kbr1
Per offline discussion, the plan is to not add these extensions to ANGLE right now, ...
10 years, 9 months ago (2013-07-19 22:57:27 UTC) #5
jun.a.jiang
10 years, 9 months ago (2013-07-22 02:57:19 UTC) #6
On 2013/07/19 22:57:27, kbr1 wrote:
> Per offline discussion, the plan is to not add these extensions to ANGLE right
> now, but instead to wait until the ES 3.0 branch is ready for external
> contributions, and implement them against that branch.

Yes, it seems better to add these extensions at a latter time. As I mentioned in
https://codereview.chromium.org/18246005/ before, rendering to FP32 textures
works well for DX9 only. When forcing to use ANGLE DX11, it seems only R32_FLOAT
and R32G32_FLOAT are renderable on Intel Graphics Cards(HD4000) on win7. In the
efforts of transition to use DX11 for ANGLE recently, there may be some more
work to be finished to support rendering to FP32 textures.
When the time comes for these extension, I'd like to pick up this issue again or
help to do some work on the compatibility issue with Intel Graphics Cards.
Meanwhile, I am open that some committers in ANGLE can help to refine this code
and land it into ANGLE directly.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b