Visual updates to sharing links

Visual updates to sharing links

Per design changes, the sharing links are now permanently visible in charm
details. This branch makes them part of the charm details view; the links are
added to the template, and the (very minor) bit of behavior they have is added
to the view. Specifically:
-There is a new event for '#sharing a' which handles opening them in a new tab.
-Render now generates the extra data for the sharing links
Additionally the old sharing stuff is ripped out.

https://code.launchpad.net/~jcsackett/juju-gui/sharing-visual-update/+merge/174507

(do not edit description out of merge proposal)

[j.c.sackett, 2013-07-12 21:12:31]

Please take a look.

[curtis, 2013-07-12 21:35:35]

Hi Jon. Thank you for this grand simplification of Sharing. I am very concerned
about window.location.origin compatibility. I think we need to be certain IE 10
and all the FFs we support love this.

https://codereview.appspot.com/11230043/diff/1/app/subapps/browser/views/char...
File app/subapps/browser/views/charm.js (right):

https://codereview.appspot.com/11230043/diff/1/app/subapps/browser/views/char...
app/subapps/browser/views/charm.js:648: link = window.location.origin + '/' +
this.get('charm').get('id'),
Does IE10 support window.location.origin? FF did not last year. I see FF does as
of v21. I am not saying this is wrong, but I recall fixing the IE
window.location.pathname issues in Lp in May 2012, and there were issues with
origin. We may be to construct the value using something like:
    var loc = window.location
    loc.protocol + "//" + loc.hostname + ":" + loc.port

[curtis, 2013-07-12 21:40:31]

I see this pattern in all places that use location.origin:
    return location.origin || (location.protocol + '//' + location.host);

I think I was wrong about the port. I am reassured that we have examples of how
to handle this case in the JS we use. I am willing to trade a LGTM if you revise
the use of origin,

[j.c.sackett, 2013-07-12 22:16:33]

Please take a look.

[curtis, 2013-07-12 22:22:51]

Thank you Jon. LGTM.

[gary.poster, 2013-07-12 22:32:48]

Thank you!  LGTM with additional small style tweak.

Please use the following padding for the "#subapp-browser .charm #sharing" CSS
rule, unless you object:

padding-top: 17px;
padding-bottom: 16px;
padding-right: 26px;
padding-left: 16px;

Otherwise good.

Thank you!

Gary

[j.c.sackett, 2013-07-12 22:39:06]

On 2013/07/12 22:32:48, gary.poster wrote:
> Thank you!  LGTM with additional small style tweak.
> 
> Please use the following padding for the "#subapp-browser .charm #sharing" CSS
> rule, unless you object:
> 
> padding-top: 17px;
> padding-bottom: 16px;
> padding-right: 26px;
> padding-left: 16px;
> 
> Otherwise good.
> 
> Thank you!
> 
> Gary

No objections. Making that change and landing. Thanks!

[j.c.sackett, 2013-07-12 22:48:52]

*** Submitted:

Visual updates to sharing links

Per design changes, the sharing links are now permanently visible in charm
details. This branch makes them part of the charm details view; the links are
added to the template, and the (very minor) bit of behavior they have is added
to the view. Specifically:
-There is a new event for '#sharing a' which handles opening them in a new tab.
-Render now generates the extra data for the sharing links
Additionally the old sharing stuff is ripped out.

R=curtis, gary.poster
CC=
https://codereview.appspot.com/11230043