Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(395)

Issue 112290043: code review 112290043: src, misc: applied gofmt -s -w (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by gri
Modified:
10 years, 10 months ago
Reviewers:
gobot, dave
CC:
golang-codereviews, dave_cheney.net
Visibility:
Public.

Description

src, misc: applied gofmt -s -w Pending CL 113120043.

Patch Set 1 #

Patch Set 2 : diff -r 29e283742de1 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 29e283742de1 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 29e283742de1 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 29e283742de1 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 6 : diff -r 6f69b178e6d9 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M src/cmd/cgo/out.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/bufio/bufio_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/database/sql/sql.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/database/sql/sql_test.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/go/printer/printer_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/log/syslog/syslog_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/dial_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/exec/exec.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/malloc_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/map_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/mapspeed_test.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/race/testdata/chan_test.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/race/testdata/map_test.go View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/pkg/runtime/race/testdata/slice_test.go View 1 5 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/runtime/string_test.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/unicode/utf8/utf8.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
gri
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 10 months ago (2014-07-14 23:41:32 UTC) #1
dave_cheney.net
LGTM. Wow, I never imagined this pattern would be so common. https://codereview.appspot.com/112290043/diff/30018/src/pkg/runtime/mapspeed_test.go File src/pkg/runtime/mapspeed_test.go (right): ...
10 years, 10 months ago (2014-07-14 23:49:01 UTC) #2
gri
Yes, I was a bit surprised about the number of occurrences myself. https://codereview.appspot.com/112290043/diff/30018/src/pkg/runtime/mapspeed_test.go File src/pkg/runtime/mapspeed_test.go ...
10 years, 10 months ago (2014-07-14 23:57:17 UTC) #3
gri
*** Submitted as https://code.google.com/p/go/source/detail?r=278365dff593 *** src, misc: applied gofmt -s -w Pending CL 113120043. LGTM=dave ...
10 years, 10 months ago (2014-07-16 23:29:54 UTC) #4
gobot
10 years, 10 months ago (2014-07-17 01:25:21 UTC) #5
Message was sent while issue was closed.
This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/42e89e40df2b6fe94e3849be2316f943acec9ddb
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b