Add a home link to the search widget.

Add a home link to the search widget.

- Adds the buttons and UI for the home link.
- Updates the search widget to listen/fire events for that click
- Updates the viewNavigate to handle requests to clear/replace the current set
of search filters.

https://code.launchpad.net/~rharding/juju-gui/home-link/+merge/174482

(do not edit description out of merge proposal)

[rharding, 2013-07-12 19:23:28]

Please take a look.

[benjamin.saller, 2013-07-12 19:39:45]

Locally clicking the home icon seems to work but clicking the home link text
does nothing.

[j.c.sackett, 2013-07-12 19:47:18]

I have a few comments.

https://codereview.appspot.com/11224044/diff/3001/app/templates/browser-searc...
File app/templates/browser-search.handlebars (right):

https://codereview.appspot.com/11224044/diff/3001/app/templates/browser-searc...
app/templates/browser-search.handlebars:6: </div>
Extra spaces in class="home"

https://codereview.appspot.com/11224044/diff/3001/app/widgets/charm-search.js
File app/widgets/charm-search.js (right):

https://codereview.appspot.com/11224044/diff/3001/app/widgets/charm-search.js...
app/widgets/charm-search.js:42: * @event EV_SEARCH_CHANGED the widgets notifies
that the search input has.
Not your change, but it looks like at some point the EV_SEARCH_CHANGED doc got
chopped. "the widget notifies that the search input has." is probably supposed
to be "has changed."

https://codereview.appspot.com/11224044/diff/3001/app/widgets/charm-search.js...
app/widgets/charm-search.js:146: 'click', this._onHome, this
You have two things with the home class; this is only going to find and fire on
one.

[rharding, 2013-07-12 20:43:24]

Please take a look.

[j.c.sackett, 2013-07-12 20:58:10]

LGTM. Thanks.

[gary.poster, 2013-07-12 21:24:04]

LGTM.  qa good.

Really want the Home to disappear on the main sidebar page.  Critical fix next
week.

I feel like going home ought to clear the search text too.  Otherwise you
subsequently click on categories but search text is still there.  Another tweak
for later?

Thank you very much!

Gary

https://codereview.appspot.com/11224044/diff/6002/app/subapps/browser/templat...
File app/subapps/browser/templates/browser_charm.handlebars (left):

https://codereview.appspot.com/11224044/diff/6002/app/subapps/browser/templat...
app/subapps/browser/templates/browser_charm.handlebars:4: {{#if isFullscreen}}
breadcrumbs, alas, we barely knew ye

[benjamin.saller, 2013-07-12 21:27:17]

LGTM, did have the trivial below though

https://codereview.appspot.com/11224044/diff/6002/app/widgets/charm-search.js
File app/widgets/charm-search.js (right):

https://codereview.appspot.com/11224044/diff/6002/app/widgets/charm-search.js...
app/widgets/charm-search.js:160: ev.target.addClass('home-icon');
I'd prefer this was just the :hover pseudo selector in CSS, does that not work
for some reason? Additionally is there a story for touch interaction around
this?

[rharding, 2013-07-12 21:54:09]

Replies below

https://codereview.appspot.com/11224044/diff/6002/app/widgets/charm-search.js
File app/widgets/charm-search.js (right):

https://codereview.appspot.com/11224044/diff/6002/app/widgets/charm-search.js...
app/widgets/charm-search.js:160: ev.target.addClass('home-icon');
On 2013/07/12 21:27:17, benjamin.saller wrote:
> I'd prefer this was just the :hover pseudo selector in CSS, does that not work
> for some reason? Additionally is there a story for touch interaction around
> this?

:hover didn't work here because it needs a different css selector to load the
correct sprite using our sprite tooling. I used :hover for the Home text link
because that was safe.

As for mobile, no, there's not a mobile story that I can think of. The click
events will clear/go home without indicators since there's not really a hover
state to work with on touch.

[rharding, 2013-07-12 21:58:58]

*** Submitted:

Add a home link to the search widget.

- Adds the buttons and UI for the home link.
- Updates the search widget to listen/fire events for that click
- Updates the viewNavigate to handle requests to clear/replace the current set
of search filters.

R=benjamin.saller, j.c.sackett, gary.poster
CC=
https://codereview.appspot.com/11224044