Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2228)

Issue 11216044: Remove gallery-ellipsis.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by bac
Modified:
10 years, 9 months ago
Reviewers:
mp+174497, matthew.scott, gary.poster
Visibility:
Public.

Description

Remove gallery-ellipsis. No one is using it now. https://code.launchpad.net/~bac/juju-gui/kill-gallery-ellipsis/+merge/174497 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Remove gallery-ellipsis. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -524 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
D app/assets/javascripts/gallery-ellipsis.js View 1 chunk +0 lines, -257 lines 0 comments Download
D app/assets/javascripts/gallery-ellipsis-debug.js View 1 chunk +0 lines, -257 lines 0 comments Download
M app/modules-debug.js View 1 chunk +0 lines, -3 lines 0 comments Download
M app/templates/charm-search-result.handlebars View 1 chunk +0 lines, -3 lines 0 comments Download
M app/views/charm-panel.js View 1 chunk +1 line, -2 lines 0 comments Download
M bin/merge-files View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4
bac
Please take a look.
10 years, 9 months ago (2013-07-12 20:23:47 UTC) #1
gary.poster
LGTM. yay code deletion :-)
10 years, 9 months ago (2013-07-12 21:01:59 UTC) #2
matthew.scott
LGTM \o/
10 years, 9 months ago (2013-07-12 21:07:22 UTC) #3
bac
10 years, 9 months ago (2013-07-12 21:20:31 UTC) #4
*** Submitted:

Remove gallery-ellipsis.

No one is using it now.

R=gary.poster, matthew.scott
CC=
https://codereview.appspot.com/11216044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b