User subscription functionality

Modification of subscribe(), unsubscribe(), is_subscribed_to() methods.
If you want to check how the patch works you can pull it from my public repo.

The commit on bitbucket:
https://bitbucket.org/ana-balica/moin-2.0/commits/2ffec8cc8d97256760c62edfe9525dc4b4d0f1ef

[Thomas.J.Waldmann, 2013-07-12 23:07:28]

https://codereview.appspot.com/11215045/diff/1/MoinMoin/user.py
File MoinMoin/user.py (right):

https://codereview.appspot.com/11215045/diff/1/MoinMoin/user.py#newcode199
MoinMoin/user.py:199: def assemble_subscription(keyword, namespace, value):
if you call this for ITEMID=someitemid, you don't need to give namespace, but
there is a non-optional positional param for this.

maybe rather use a_s(k, v, n=None) ?

https://codereview.appspot.com/11215045/diff/1/MoinMoin/user.py#newcode213
MoinMoin/user.py:213: return False
raise ValueError?

https://codereview.appspot.com/11215045/diff/1/MoinMoin/user.py#newcode579
MoinMoin/user.py:579: for name in item.meta[NAME])
does this work? docstring of set.update reads like it wants another set as
argument.

https://codereview.appspot.com/11215045/diff/1/MoinMoin/user.py#newcode582
MoinMoin/user.py:582: if subscriptions & set(self.subscriptions):
self.subscriptions?

https://codereview.appspot.com/11215045/diff/1/MoinMoin/user.py#newcode589
MoinMoin/user.py:589: def subscribe(self, keyword, namespace, value):
see comment about optional namespace above.

https://codereview.appspot.com/11215045/diff/1/MoinMoin/user.py#newcode608
MoinMoin/user.py:608: return False
in-band signalling

[ana.balica, 2013-07-13 22:49:39]

https://codereview.appspot.com/11215045/diff/1/MoinMoin/user.py
File MoinMoin/user.py (right):

https://codereview.appspot.com/11215045/diff/1/MoinMoin/user.py#newcode579
MoinMoin/user.py:579: for name in item.meta[NAME])
On 2013/07/12 23:07:28, Thomas.J.Waldmann wrote:
> does this work? docstring of set.update reads like it wants another set as
> argument.

it does. set.update() accepts an iterable (list here).

https://codereview.appspot.com/11215045/diff/1/MoinMoin/user.py#newcode582
MoinMoin/user.py:582: if subscriptions & set(self.subscriptions):
On 2013/07/12 23:07:28, Thomas.J.Waldmann wrote:
> self.subscriptions?

I left the whoosh index fields called SUBSCRIPTION_IDS and
SUBSCRIPTION_PATTERNS. For revision meta decided to pick simply SUBSCRIPTIONS.
The new key names are referenced in this issue -
https://codereview.appspot.com/10693045/

[Thomas.J.Waldmann, 2013-07-14 07:51:12]

https://codereview.appspot.com/11215045/diff/1/MoinMoin/user.py
File MoinMoin/user.py (right):

https://codereview.appspot.com/11215045/diff/1/MoinMoin/user.py#newcode582
MoinMoin/user.py:582: if subscriptions & set(self.subscriptions):
that's ok, i just couldn't find where self.subscriptions is defined.

[ana.balica, 2013-07-14 08:00:55]

https://codereview.appspot.com/11215045/diff/1/MoinMoin/user.py
File MoinMoin/user.py (right):

https://codereview.appspot.com/11215045/diff/1/MoinMoin/user.py#newcode582
MoinMoin/user.py:582: if subscriptions & set(self.subscriptions):
to be precise, here: 
https://codereview.appspot.com/10693045/patch/3001/4004

[Thomas.J.Waldmann, 2013-07-14 08:19:42]

https://codereview.appspot.com/11215045/diff/1/MoinMoin/user.py
File MoinMoin/user.py (right):

https://codereview.appspot.com/11215045/diff/1/MoinMoin/user.py#newcode582
MoinMoin/user.py:582: if subscriptions & set(self.subscriptions):
ok