Issue 1121043: fixed bug on not recording shape change
Patch Set 1 #
Total comments: 6
Patch Set 2 : updated and bug fixed #
Total comments: 1
Patch Set 3 : updated #MessagesTotal messages: 8
http://codereview.appspot.com/1121043/diff/1/2 File gtfsscheduleviewer/files/transit_editor.js (right): http://codereview.appspot.com/1121043/diff/1/2#newcode3291 gtfsscheduleviewer/files/transit_editor.js:3291: this.firstSub.setColor(color); It seems that this line is not needed anymore, isn't it? http://codereview.appspot.com/1121043/diff/1/2#newcode3300 gtfsscheduleviewer/files/transit_editor.js:3300: anchor = leg.toAnchor; I don't see why we need to change the variable "anchor", even I think we don't need this variable in the function scope at all. To be clear, var leg = this.firstSub; while (leg) { leg.setColor(color); if (leg.toAnchor = this.endAnchor) { return; } if (leg.toAnchor) { leg = leg.toAnchor.toLeg; } else { break; } } http://codereview.appspot.com/1121043/diff/1/2#newcode3303 gtfsscheduleviewer/files/transit_editor.js:3303: break; In which case a leg doesn't have toAnchor?
Sign in to reply to this message.
updated and bug fixed http://codereview.appspot.com/1121043/diff/1/2 File gtfsscheduleviewer/files/transit_editor.js (right): http://codereview.appspot.com/1121043/diff/1/2#newcode3291 gtfsscheduleviewer/files/transit_editor.js:3291: this.firstSub.setColor(color); On 2010/05/07 02:47:58, baiming wrote: > It seems that this line is not needed anymore, isn't it? Done. http://codereview.appspot.com/1121043/diff/1/2#newcode3300 gtfsscheduleviewer/files/transit_editor.js:3300: anchor = leg.toAnchor; On 2010/05/07 02:47:58, baiming wrote: > I don't see why we need to change the variable "anchor", even I think we don't > need this variable in the function scope at all. > > To be clear, > var leg = this.firstSub; > while (leg) { > leg.setColor(color); > if (leg.toAnchor = this.endAnchor) { > return; > } > if (leg.toAnchor) { > leg = leg.toAnchor.toLeg; > } else { > break; > } > } Done. http://codereview.appspot.com/1121043/diff/1/2#newcode3303 gtfsscheduleviewer/files/transit_editor.js:3303: break; On 2010/05/07 02:47:58, baiming wrote: > In which case a leg doesn't have toAnchor? Done.
Sign in to reply to this message.
LGTM Thanks for the fix. http://codereview.appspot.com/1121043/diff/5001/1002 File gtfsscheduleviewer/files/transit_editor.js (right): http://codereview.appspot.com/1121043/diff/5001/1002#newcode3125 gtfsscheduleviewer/files/transit_editor.js:3125: this.fromListener = from.addListener('dragend', this, this.onFromStopDragEnd); Line exceeds 80 chars limit.
Sign in to reply to this message.
updated to rev 78 2010/5/7 <baiming@google.com> > LGTM > > Thanks for the fix. > > > http://codereview.appspot.com/1121043/diff/5001/1002 > > File gtfsscheduleviewer/files/transit_editor.js (right): > > http://codereview.appspot.com/1121043/diff/5001/1002#newcode3125 > gtfsscheduleviewer/files/transit_editor.js:3125: this.fromListener = > from.addListener('dragend', this, this.onFromStopDragEnd); > Line exceeds 80 chars limit. > > > http://codereview.appspot.com/1121043/show >
Sign in to reply to this message.
之前测试的问题 点击线路名称，没有绘线路，点击trips绘制。 当改变stop到位置后，再去变化小红点到位置， SHAPE还会从原来到位置计算（可 能那个STOP到位置还没有保存到原因） //paulo-sao-br-200807011834.zip 中 线路C generate shape的时候，shape混乱 线路F 第一个stop稍微变化一点位置，shape 就变成另外到样子了。 //boston-ma-us-201004162204 20M 大数据 点击路名称，打不开，超时了 http://localhost:8765/json/tripsbyrid?rid=731-1062 这个请求 //shanghai-cn-201004090255.zip 中 点击路线名，可以绘制出SHAPE，刚才那个需要 点击 trips 新添加的站点，没有时间 在 2010年5月10日 上午9:50，李白，字一日 <calidion@gmail.com>写道： > updated to rev 78 > > 2010/5/7 <baiming@google.com> > > LGTM >> >> Thanks for the fix. >> >> >> http://codereview.appspot.com/1121043/diff/5001/1002 >> >> File gtfsscheduleviewer/files/transit_editor.js (right): >> >> http://codereview.appspot.com/1121043/diff/5001/1002#newcode3125 >> gtfsscheduleviewer/files/transit_editor.js:3125: this.fromListener = >> from.addListener('dragend', this, this.onFromStopDragEnd); >> Line exceeds 80 chars limit. >> >> >> http://codereview.appspot.com/1121043/show >> > >
Sign in to reply to this message.
Please file bugs in http://code.google.com/p/scheduleeditor/issues/list (New issue <http://code.google.com/p/scheduleeditor/issues/entry>) and prioritize them. We should fix the high priority ones first. Thanks! On Mon, May 10, 2010 at 10:59 AM, 光贾 <heian911@gmail.com> wrote: > 之前测试的问题 > > 点击线路名称，没有绘线路，点击trips绘制。 > 当改变stop到位置后，再去变化小红点到位置， > SHAPE还会从原来到位置计算（可 能那个STOP到位置还没有保存到原因） > //paulo-sao-br-200807011834.zip 中 > 线路C generate shape的时候，shape混乱 > 线路F 第一个stop稍微变化一点位置，shape 就变成另外到样子了。 > > //boston-ma-us-201004162204 20M 大数据 > 点击路名称，打不开，超时了 > http://localhost:8765/json/tripsbyrid?rid=731-1062 这个请求 > > //shanghai-cn-201004090255.zip 中 > 点击路线名，可以绘制出SHAPE，刚才那个需要 点击 trips > 新添加的站点，没有时间 > > > 在 2010年5月10日 上午9:50，李白，字一日 <calidion@gmail.com>写道： > > updated to rev 78 >> >> 2010/5/7 <baiming@google.com> >> >> LGTM >>> >>> Thanks for the fix. >>> >>> >>> http://codereview.appspot.com/1121043/diff/5001/1002 >>> >>> File gtfsscheduleviewer/files/transit_editor.js (right): >>> >>> http://codereview.appspot.com/1121043/diff/5001/1002#newcode3125 >>> gtfsscheduleviewer/files/transit_editor.js:3125: this.fromListener = >>> from.addListener('dragend', this, this.onFromStopDragEnd); >>> Line exceeds 80 chars limit. >>> >>> >>> http://codereview.appspot.com/1121043/show >>> >> >> > -- Best Regards, Wei Liu 86-10-62503256(o)
Sign in to reply to this message.
On Mon, May 10, 2010 at 11:01 AM, Wei Liu <weiliu@google.com> wrote: > Please file bugs in http://code.google.com/p/scheduleeditor/issues/list (New > issue <http://code.google.com/p/scheduleeditor/issues/entry>) and > prioritize them. We should fix the high priority ones first. > > Thanks! > > On Mon, May 10, 2010 at 10:59 AM, 光贾 <heian911@gmail.com> wrote: > >> 之前测试的问题 >> >> 点击线路名称，没有绘线路，点击trips绘制。 >> > p2 > 当改变stop到(*的?*)位置后，再去变化小红点到(*的*)位置， >> SHAPE还会从原来到位置计算（可 能那个STOP到位置还没有保存到原因） >> > p1 > //paulo-sao-br-200807011834.zip 中 >> 线路C generate shape的时候，shape混乱 >> > 请发截图 > 线路F 第一个stop稍微变化一点位置，shape 就变成另外到样子了。 >> > 是整个shape都被影响了，还是只有与第一个stop相邻的leg变化？请发截图 > >> //boston-ma-us-201004162204 20M 大数据 >> 点击路名称，打不开，超时了 >> http://localhost:8765/json/tripsbyrid?rid=731-1062 这个请求 >> > p0 > >> //shanghai-cn-201004090255.zip 中 >> 点击路线名，可以绘制出SHAPE，刚才那个需要 点击 trips >> 新添加的站点，没有时间 >> > 请详细点说明问题 > >> >> 在 2010年5月10日 上午9:50，李白，字一日 <calidion@gmail.com>写道： >> >> updated to rev 78 >>> >>> 2010/5/7 <baiming@google.com> >>> >>> LGTM >>>> >>>> Thanks for the fix. >>>> >>>> >>>> http://codereview.appspot.com/1121043/diff/5001/1002 >>>> >>>> File gtfsscheduleviewer/files/transit_editor.js (right): >>>> >>>> http://codereview.appspot.com/1121043/diff/5001/1002#newcode3125 >>>> gtfsscheduleviewer/files/transit_editor.js:3125: this.fromListener = >>>> from.addListener('dragend', this, this.onFromStopDragEnd); >>>> Line exceeds 80 chars limit. >>>> >>>> >>>> http://codereview.appspot.com/1121043/show >>>> >>> >>> >> > > > -- > Best Regards, > Wei Liu > 86-10-62503256(o) >
Sign in to reply to this message.
|
