Issue 11209044: Bootstrap Reviews

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11209044: Bootstrap Reviews

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by sharky93

Modified:
10 years, 10 months ago

Reviewers:
thomas.j.waldmann, TheSheep

Visibility:
Public.

More Reviews

Description

This will list several patchsets, which will be further pushed onto the main repo after review. A stack is being used in mercurial (mq) Patchset involving local panel, 7-10, has a bug. (some itemviews are not listed in the local panel) ^ Fixed by Patchset 11

Patch Set 1 #

Patch Set 2 : Added topnav #

Patch Set 3 : Global nav, quick links, commoncss #

Patch Set 4 : Adds breadcrumbs #

Total comments: 1

Patch Set 5 : Adds tabs for itemviews, content display #

Patch Set 6 : adds struct for localpanel #

Patch Set 7 : adds struct for localpanel in show #

Patch Set 8 : Adds useractions in localpanel #

Patch Set 9 : Adds site actions to localpanel #

Patch Set 10 : Adds item actions to local panel #

Patch Set 11 : Fixes missing itemviews in local panel #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	MoinMoin/themes/basic/templates/show.html	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Thomas.J.Waldmann

if i click on view (overall changes, over all patchsets), I just see a 1 ...

10 years, 10 months ago (2013-07-14 00:00:22 UTC) #1

sharky93

On 2013/07/14 00:00:22, Thomas.J.Waldmann wrote: > if i click on view (overall changes, over all ...

10 years, 10 months ago (2013-07-14 03:03:08 UTC) #2

TheSheep

10 years, 10 months ago (2013-07-15 12:19:47 UTC) #3

https://codereview.appspot.com/11209044/diff/13001/MoinMoin/themes/basic/temp...
File MoinMoin/themes/basic/templates/layout.html (right):

https://codereview.appspot.com/11209044/diff/13001/MoinMoin/themes/basic/temp...
MoinMoin/themes/basic/templates/layout.html:123: <span class="divider">/</span>
Only show divider if this is not the last element.

Expand All Messages | Collapse All Messages