Issue 11209043: Another round of visual updates.

Issue 11209043: Another round of visual updates. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by huwshimi

Modified:
10 years, 9 months ago

Reviewers:
bac, luca.paulina, benji, mp+174347, rharding, jeff.pihach

Visibility:
Public.

Description

Another round of visual updates. Implements feedback from Luca. Also fixes extra scrollbar bug by hiding overflow on the body. https://code.launchpad.net/~huwshimi/juju-gui/visual-update-5/+merge/174347 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 10

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+154 lines, -88 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/templates/search.handlebars	View	1 chunk	+23 lines, -21 lines	6 comments	Download
M	app/subapps/browser/views/search.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/views/browser/charm-full.less	View	3 chunks	+12 lines, -5 lines	0 comments	Download
M	lib/views/browser/charm-token.less	View	2 chunks	+6 lines, -4 lines	2 comments	Download
M	lib/views/browser/editorial.less	View	1 chunk	+12 lines, -10 lines	0 comments	Download
M	lib/views/browser/main.less	View	6 chunks	+42 lines, -44 lines	0 comments	Download
A	lib/views/browser/search.less	View	1 chunk	+49 lines, -0 lines	0 comments	Download
M	lib/views/stylesheet.less	View	2 chunks	+6 lines, -2 lines	2 comments	Download

Messages

Total messages: 10

Expand All Messages | Collapse All Messages

rharding

code looks ok. I'm not sure why we removed the results count though. Will QA ...

10 years, 9 months ago (2013-07-12 13:28:28 UTC) #2

benji

not LGTM We need to resolve the body overflow issue before landing. Other than that ...

10 years, 9 months ago (2013-07-12 13:32:36 UTC) #3

bac

Not LGTM Other than what I've noted, I don't see anything to comment on from ...

10 years, 9 months ago (2013-07-12 13:53:34 UTC) #6

bac

LGTM now https://codereview.appspot.com/11209043/diff/1/app/subapps/browser/templates/search.handlebars File app/subapps/browser/templates/search.handlebars (right): https://codereview.appspot.com/11209043/diff/1/app/subapps/browser/templates/search.handlebars#newcode2 app/subapps/browser/templates/search.handlebars:2: <div class="content yui3-g"> On 2013/07/12 13:53:34, bac ...

10 years, 9 months ago (2013-07-12 14:30:46 UTC) #8

jeff.pihach

This is only QA: w/o the serviceInspector flag (blocking) -the ghost config no longer takes ...

10 years, 9 months ago (2013-07-12 14:35:17 UTC) #9

benji

10 years, 9 months ago (2013-07-12 15:06:51 UTC) #10

On 2013/07/12 13:32:36, benji wrote:
> We need to resolve the body overflow issue before landing.

I can't reproduce the test problem with the overflow, so this LGTM.

Expand All Messages | Collapse All Messages