AppData Support for Myspace

This patch adds provider specific fixes for Myspace and appData. It also fixes a bug in the curlProvider that caused issues with appdata.delete

[Arne Roomann-Kurrik, 2009-08-31 20:58:18]

Note that I also commented out a reference to a file which didn't exist in my
SVN client:

http://code.google.com/p/opensocial-php-client/source/detail?r=188

Currently, the osapiAppDataModel class doesn't exist in the svn repository:
http://code.google.com/p/opensocial-php-client/source/browse/#svn/trunk/src/o...

If your code requires this file, please add it to this patch.

http://codereview.appspot.com/112054/diff/1/2
File src/examples/appData.php (left):

http://codereview.appspot.com/112054/diff/1/2#oldcode94
Line 94: 
Why are you removing these comments?

http://codereview.appspot.com/112054/diff/1/3
File src/osapi/io/osapiCurlProvider.php (right):

http://codereview.appspot.com/112054/diff/1/3#newcode55
Line 55: curl_setopt($ch, CURLOPT_CUSTOMREQUEST, $method);
Will this work with GET requests?  It seems like it should, I just wonder why we
had the if/then there in the first place.

[Harakiro, 2009-08-31 21:10:21]

Will add the appDataModel. In the future it would be nice for all services to
use this data container but wanted to discuss it first before making this
change. For now I've added these fixes to make myspaces data conform to
'current' spec.

I know that the v0.9 spec is still in debates about how appData should be
strucutured.

http://codereview.appspot.com/112054/diff/1/2
File src/examples/appData.php (left):

http://codereview.appspot.com/112054/diff/1/2#oldcode94
Line 94: 
On 2009/08/31 20:58:18, Arne Roomann-Kurrik wrote:
> Why are you removing these comments?

Just a bit of cleanup. I changed the value of what osapiFoo1 is setup to to use
a time so you can always see it in fact updates. Also the comments mention
getAppData which is never used. This the sample was inaccurate. Also it makes
reference to checking against $result[$idx] w/o explanation of what idx was.

The code that checks for a osapiError now lives in  the include and commenting
for "what" that check is doing should live in there.

http://codereview.appspot.com/112054/diff/1/3
File src/osapi/io/osapiCurlProvider.php (right):

http://codereview.appspot.com/112054/diff/1/3#newcode55
Line 55: curl_setopt($ch, CURLOPT_CUSTOMREQUEST, $method);
On 2009/08/31 20:58:18, Arne Roomann-Kurrik wrote:
> Will this work with GET requests?  It seems like it should, I just wonder why
we
> had the if/then there in the first place.

Yes this works fine for GET. I'm not sure why this code was there in the first
place.

[Harakiro, 2009-08-31 21:27:37]

added AppDataModel, removed internal debug endpoint

[opensocial.coderunner, 2009-09-01 18:10:56]

On 2009/08/31 21:27:37, Harakiro wrote:
> added AppDataModel, removed internal debug endpoint

LGTM