Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(62)

Issue 11201043: code review 11201043: misc/cgo/test: make test work with -linkmode=internal (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by rsc
Modified:
12 years, 11 months ago
Reviewers:
minux1
CC:
minux1, golang-dev
Visibility:
Public.

Description

misc/cgo/test: make test work with -linkmode=internal The static func named thread in issue5337.go's C snippet conflicts with the static func named thread in issue3350.go's C snippet. I don't know why (they're both static) but I also don't care, because -linkmode=internal only needs to be able to handle the cgo in the standard library, and it does. Change the test to avoid this problem. Fixes build (after run.bash is fixed to detect the breakage).

Patch Set 1 #

Patch Set 2 : diff -r 9c7e1d1fe912 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 9c7e1d1fe912 https://code.google.com/p/go/ #

Patch Set 4 : diff -r d75933428602 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M misc/cgo/test/issue5337.go View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello minux.ma@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years, 11 months ago (2013-07-12 03:24:18 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=49f08e8cd312 *** misc/cgo/test: make test work with -linkmode=internal The static func named ...
12 years, 11 months ago (2013-07-12 03:24:38 UTC) #2
minux1
12 years, 11 months ago (2013-07-12 04:29:14 UTC) #3
LGTM.

In fact, i've mailed out a CL to fix this problem on Darwin and Windows:
https://codereview.appspot.com/10345046/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b