Issue 11199043: code review 11199043: cmd/5l, cmd/6l, cmd/8l: increase error buffer size

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11199043: code review 11199043: cmd/5l, cmd/6l, cmd/8l: increase error buffer size (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by rsc

Modified:
11 years, 9 months ago

Reviewers:

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/5l, cmd/6l, cmd/8l: increase error buffer size STRINGSZ (200) is fine for lines generated by things like instruction dumps, but an error containing a couple file names can easily exceed that, especially on Macs with the ridiculous default $TMPDIR.

Patch Set 1 #

Patch Set 2 : diff -r d607f47f640d https://code.google.com/p/go/ #

Patch Set 3 : diff -r d607f47f640d https://code.google.com/p/go/ #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
M	src/cmd/5l/list.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/6l/list.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/8l/list.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 9 months ago (2013-07-12 02:49:12 UTC) #1

rsc

11 years, 9 months ago (2013-07-12 02:49:18 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=072c72aa0c17 ***

cmd/5l, cmd/6l, cmd/8l: increase error buffer size

STRINGSZ (200) is fine for lines generated by things like
instruction dumps, but an error containing a couple file
names can easily exceed that, especially on Macs with
the ridiculous default $TMPDIR.

R=ken2
CC=golang-dev
https://codereview.appspot.com/11199043

Expand All Messages | Collapse All Messages