Fixes inspector position and adds scrolling

Fixes inspector position and adds scrolling

The inspector position is now locked to a 20px buffer on
the right side of the environment. It's max height
is constrained to this buffer but it can be as small as
the visible viewlet allows.

https://code.launchpad.net/~hatch/juju-gui/size-scroll-position-inspector/+merge/174290

(do not edit description out of merge proposal)

[jeff.pihach, 2013-07-11 20:39:21]

Please take a look.

[jeff.pihach, 2013-07-11 20:43:01]

Please take a look.

[j.c.sackett, 2013-07-11 20:52:02]

LGTM, with one remark.

https://codereview.appspot.com/11186043/diff/4001/app/views/view-container.js
File app/views/view-container.js (right):

https://codereview.appspot.com/11186043/diff/4001/app/views/view-container.js...
app/views/view-container.js:406: // 20 is a fudge value to catch the various
'secret' margins and borders.
You could just define these as two separate vars at the top, e.g. `var
TOP_BOTTOM_SPACING = 20` which would make the code self documenting rather than
needing this comment.

[benjamin.saller, 2013-07-11 21:35:27]

LGTM

I like jc's suggestion and I think you set the wrong style.
https://developer.mozilla.org/en-US/docs/Web/CSS/max-height

Are you seeing that get applied in the devtools?

https://codereview.appspot.com/11186043/diff/4001/app/views/service.js
File app/views/service.js (right):

https://codereview.appspot.com/11186043/diff/4001/app/views/service.js#newcod...
app/views/service.js:1625: 
Sad to see it go

https://codereview.appspot.com/11186043/diff/4001/app/views/view-container.js
File app/views/view-container.js (right):

https://codereview.appspot.com/11186043/diff/4001/app/views/view-container.js...
app/views/view-container.js:412: .setStyle('maxHeight', height + 'px');
I thought this was max-height? No?

[jeff.pihach, 2013-07-11 21:40:49]

Thanks for the reviews!

https://codereview.appspot.com/11186043/diff/4001/app/views/service.js
File app/views/service.js (right):

https://codereview.appspot.com/11186043/diff/4001/app/views/service.js#newcod...
app/views/service.js:1625: 
maybe when no one is looking we can add it back in under a super secret flag

https://codereview.appspot.com/11186043/diff/4001/app/views/view-container.js
File app/views/view-container.js (right):

https://codereview.appspot.com/11186043/diff/4001/app/views/view-container.js...
app/views/view-container.js:406: // 20 is a fudge value to catch the various
'secret' margins and borders.
On 2013/07/11 20:52:02, j.c.sackett wrote:
> You could just define these as two separate vars at the top, e.g. `var
> TOP_BOTTOM_SPACING = 20` which would make the code self documenting rather
than
> needing this comment.

Done.

https://codereview.appspot.com/11186043/diff/4001/app/views/view-container.js...
app/views/view-container.js:412: .setStyle('maxHeight', height + 'px');
setStyle sets the js style property which has camelCased names

[jeff.pihach, 2013-07-11 22:04:29]

*** Submitted:

Fixes inspector position and adds scrolling

The inspector position is now locked to a 20px buffer on
the right side of the environment. It's max height
is constrained to this buffer but it can be as small as
the visible viewlet allows.

R=j.c.sackett, benjamin.saller
CC=
https://codereview.appspot.com/11186043