Issue 111860043: Fix quickstart for Juju 1.20.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 111860043: Fix quickstart for Juju 1.20.

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by frankban

Modified:
9 years, 10 months ago

Reviewers:
bac, mp+225665

Visibility:
Public.

Description

Fix quickstart for Juju 1.20. In the addresses included in the MachineInfo, replace NetworkScope with Scope, falling back to NetworkScope for backwards compatibility. Tests: make check QA: Run quickstart with both 1.18 and 1.20 versions of Juju. https://code.launchpad.net/~frankban/juju-quickstart/fix-120/+merge/225665 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix quickstart for Juju 1.20. #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -24 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	quickstart/__init__.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	quickstart/tests/test_app.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	quickstart/tests/test_watchers.py	View	5 chunks	+31 lines, -14 lines	0 comments	Download
M	quickstart/watchers.py	View	3 chunks	+9 lines, -8 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bac

LGTM https://codereview.appspot.com/111860043/diff/1/quickstart/watchers.py File quickstart/watchers.py (right): https://codereview.appspot.com/111860043/diff/1/quickstart/watchers.py#newcode83 quickstart/watchers.py:83: scope = address.get('Scope', address.get('NetworkScope')) Nice fix.

9 years, 10 months ago (2014-07-04 13:29:57 UTC) #2

frankban

9 years, 10 months ago (2014-07-04 13:49:04 UTC) #4

*** Submitted:

Fix quickstart for Juju 1.20.

In the addresses included in the MachineInfo, 
replace NetworkScope with Scope, falling back to
NetworkScope for backwards compatibility.

Tests:
make check

QA:
Run quickstart with both 1.18 and 1.20 versions of Juju.

R=bac
CC=
https://codereview.appspot.com/111860043

Expand All Messages | Collapse All Messages