Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2213)

Issue 11182044: Move zoom slider to the side.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by bac
Modified:
10 years, 8 months ago
Reviewers:
mp+174286, benjamin.saller, benji
Visibility:
Public.

Description

Move zoom slider to the side. This branch uses the current assets, the default yui3-sam-skin. Assets are available for doing the final work but they are not in a form that can be used at the moment, so this work is landing without the final styling. https://code.launchpad.net/~bac/juju-gui/move-zoom/+merge/174286 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 6

Patch Set 2 : Move zoom slider to the side. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -29 lines) Patch
M Makefile View 1 4 chunks +42 lines, -15 lines 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/templates/overview.handlebars View 1 1 chunk +1 line, -6 lines 0 comments Download
A app/templates/right-sidebar.partial View 1 chunk +5 lines, -0 lines 0 comments Download
M app/views/topology/panzoom.js View 1 chunk +6 lines, -2 lines 0 comments Download
M lib/views/stylesheet.less View 1 4 chunks +34 lines, -6 lines 0 comments Download

Messages

Total messages: 4
bac
Please take a look.
10 years, 8 months ago (2013-07-11 20:18:19 UTC) #1
benjamin.saller
LGTM Thanks, rotate(90) was a cool way to do that.
10 years, 8 months ago (2013-07-11 20:26:50 UTC) #2
benji
LGTM, I just had a few fleeting thoughts. https://codereview.appspot.com/11182044/diff/1/Makefile File Makefile (right): https://codereview.appspot.com/11182044/diff/1/Makefile#newcode318 Makefile:318: build-shared/juju-ui/assets/combined-css/thumb-y.png ...
10 years, 8 months ago (2013-07-11 20:26:56 UTC) #3
bac
10 years, 8 months ago (2013-07-11 21:29:07 UTC) #4
*** Submitted:

Move zoom slider to the side.

This branch uses the current assets, the default yui3-sam-skin.  Assets
are available for doing the final work but they are not in a form that can
be used at the moment, so this work is landing without the final styling.

R=benji
CC=
https://codereview.appspot.com/11182044

https://codereview.appspot.com/11182044/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/11182044/diff/1/Makefile#newcode318
Makefile:318: build-shared/juju-ui/assets/combined-css/thumb-y.png
On 2013/07/11 20:26:57, benji wrote:
> It would be nice if these (admittedly pre-existing) long lines could be
> shortened.  Maybe moving the "from" path onto its own line plus a less
> aggressive indent width.

Done.

https://codereview.appspot.com/11182044/diff/1/Makefile#newcode520
Makefile:520: # /juju-ui directory existing.	We are vaguely trying to
approximate the second
Yeah, my emacs went crazy and detabified the whole file when I saved it.   This
tab got in when I fixed the first mistake. Irritating.

https://codereview.appspot.com/11182044/diff/1/app/templates/overview.handlebars
File app/templates/overview.handlebars (right):

https://codereview.appspot.com/11182044/diff/1/app/templates/overview.handleb...
app/templates/overview.handlebars:33: <div class="right-sidebar">
On 2013/07/11 20:26:57, benji wrote:
> Would it be cleaner if this wrapper div were in the partial instead?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b