code review 111780043: nacltest.bash: nacl/arm support.

nacltest.bash: nacl/arm support.
Also detect GOARCH automatically based on `uname -m`.

[minux, 2014-07-02 00:31:40]

Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[crawshaw, 2014-07-08 15:12:47]

LGTM

[dave_cheney.net, 2014-07-09 03:47:59]

LGTM with minor comments.

https://codereview.appspot.com/111780043/diff/40001/src/nacltest.bash
File src/nacltest.bash (right):

https://codereview.appspot.com/111780043/diff/40001/src/nacltest.bash#newcode18
src/nacltest.bash:18: if [ -z "$naclGOARCH" ]; then
should this be [ -z "$GOARCH" ] ? then leave naclGOARCH unset above

https://codereview.appspot.com/111780043/diff/40001/src/nacltest.bash#newcode28
src/nacltest.bash:28: ;;
add a default case that aborts the build

[minux, 2014-07-09 04:14:41]

https://codereview.appspot.com/111780043/diff/40001/src/nacltest.bash
File src/nacltest.bash (right):

https://codereview.appspot.com/111780043/diff/40001/src/nacltest.bash#newcode18
src/nacltest.bash:18: if [ -z "$naclGOARCH" ]; then
On 2014/07/09 03:47:59, dfc wrote:
> should this be [ -z "$GOARCH" ] ? then leave naclGOARCH unset above
we still need to do the assignment in case the user has set GOARCH.

https://codereview.appspot.com/111780043/diff/40001/src/nacltest.bash#newcode28
src/nacltest.bash:28: ;;
On 2014/07/09 03:47:59, dfc wrote:
> add a default case that aborts the build
the default case is at line 54.

[dave_cheney.net, 2014-07-09 04:20:17]

LGTM.

[rsc, 2014-07-09 19:28:23]

LGTM

https://codereview.appspot.com/111780043/diff/40001/src/nacltest.bash
File src/nacltest.bash (right):

https://codereview.appspot.com/111780043/diff/40001/src/nacltest.bash#newcode32
src/nacltest.bash:32: echo "Will build for nacl/$naclGOARCH."
delete.
make.bash will show this

[minux, 2014-07-10 19:15:44]

*** Submitted as https://code.google.com/p/go/source/detail?r=6e252e92c2de ***

nacltest.bash: nacl/arm support.
Also detect GOARCH automatically based on `uname -m`.

LGTM=crawshaw, dave, rsc
R=rsc, iant, crawshaw, dave
CC=golang-codereviews
https://codereview.appspot.com/111780043