Add --internal-diff to svn diff to ignore user's runtime configuration.

It's not uncommon for Subversion users to configure a graphical diff
tool to be used for svn diff, which will generate no output that is
useful for upload.py when invoking svn diff. A better default would
therefore be to invoke svn diff --internal-diff which always will
generate output on a format suitable for upload.py consumption.

[Andi, 2014-07-30 09:44:01]

[changing reviewers, I'm currently not able to do any reviews, sorry]

[markus.icu, 2014-07-30 15:44:23]

FYI: Thanks! Fredrik saw me struggle with this yesterday :-)

Note: I believe that the --internal-diff option was added to the svn command
line only a couple of years ago, so if someone is still using an old version
(haven't looked at the version number but probably one that ships with Ubuntu
12.04 LTS) might have this break.

[roubert (google), 2014-08-12 00:36:13]

Has anybody had time to take a look at this patch yet?

[roubert (google), 2014-12-02 19:30:45]

Has anybody had time to take a look at this patch yet?

[jrobbins (corp), 2014-12-02 20:16:35]

lgtm.  I can land this change for you.

[roubert (google), 2014-12-02 20:20:30]

On 2014/12/02 20:16:35, jrobbins (corp) wrote:
> lgtm.  I can land this change for you.

Great, thanks!

[jrobbins (corp), 2014-12-03 21:42:05]

Committed as
https://code.google.com/p/rietveld/source/detail?r=4bb5702be343547c81157add5b...

[markus.icu, 2014-12-10 00:38:44]

On Wed, Jul 30, 2014 at 8:44 AM, <markus.icu@gmail.com> wrote:

> FYI: Thanks! Fredrik saw me struggle with this yesterday :-)
>
> Note: I believe that the --internal-diff option was added to the svn
> command line only a couple of years ago, so if someone is still using an
> old version (haven't looked at the version number but probably one that
> ships with Ubuntu 12.04 LTS) might have this break.
>
> https://codereview.appspot.com/111700044/
>

I saw that this is now fixed in the repository
<https://code.google.com/p/rietveld/source/detail?spec=svn4bb5702be343547c8115...>,
but https://codereview.appspot.com/static/upload.py is not yet updated.
Please do so.

Thanks,
markus