Visual updates to the browser.

Visual updates to the browser.

Improved the visuals as per the latest mockups and feedback from Luca.

https://code.launchpad.net/~huwshimi/juju-gui/visual-update-4/+merge/174161

(do not edit description out of merge proposal)

[huwshimi, 2013-07-11 10:43:26]

Please take a look.

[rharding, 2013-07-11 10:56:23]

Generally this is ok from the code point of view. The active state for the nav
controls needs to be in the controls widget and not in the subapp main code. 

I'll QA in a bit to check for any issues visually.

https://codereview.appspot.com/11160043/diff/1/app/subapps/browser/browser.js
File app/subapps/browser/browser.js (right):

https://codereview.appspot.com/11160043/diff/1/app/subapps/browser/browser.js...
app/subapps/browser/browser.js:72: _updateActiveNav: function() {
this should be part of the widgets for the nav controls.

https://codereview.appspot.com/11160043/diff/1/app/subapps/browser/views/edit...
File app/subapps/browser/views/editorial.js (left):

https://codereview.appspot.com/11160043/diff/1/app/subapps/browser/views/edit...
app/subapps/browser/views/editorial.js:116: var containerCfg = {
It seems you could keep this shared config and just override it in the featured
case where you're using large for fullscreen and small the rest of the time.

https://codereview.appspot.com/11160043/diff/1/lib/views/browser/main.less
File lib/views/browser/main.less (right):

https://codereview.appspot.com/11160043/diff/1/lib/views/browser/main.less#ne...
lib/views/browser/main.less:120: }
spacing is off here

[rharding, 2013-07-11 11:55:07]

QA Notes:

- The providers are underlined and look like links.
- There's on breadcrumbs on search atm.
- Downloads aren't showing under the related charms icons. (Sorry, existing bug)
- Recent activity is a misnomer as the download count is total. This also wraps
and newlines after the commit count which makes reading the line hard to read.

I'll submit a patch or something for the controls fix to help aid in getting
this moving. Aside from that it's mostly cosmetic QA issues I can see and can be
addressed in follow up.

[rharding, 2013-07-11 13:02:42]

I've pushed up a branch that moves the active logic to the control widget here:

https://code.launchpad.net/~rharding/juju-gui/visual-update-4

[rharding, 2013-07-11 13:05:39]

LGTM on this branch so long as my changes to the updateActiveNav are pulled into
play.

[huwshimi, 2013-07-11 23:07:00]

Please take a look.

[huwshimi, 2013-07-11 23:23:28]

*** Submitted:

Visual updates to the browser.

Improved the visuals as per the latest mockups and feedback from Luca.

R=rharding
CC=
https://codereview.appspot.com/11160043