Issue 111600043: code review 111600043: vbackup: fix compilation on NetBSD (thanks Álvaro Jurado)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 111600043: code review 111600043: vbackup: fix compilation on NetBSD (thanks Álvaro Jurado) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by 0intro

Modified:
9 years, 6 months ago

Reviewers:
rsc

CC:
rsc, elbingmiss_gmail.com

Visibility:
Public.

Description

vbackup: fix compilation on NetBSD (thanks Álvaro Jurado) On NetBSD 5.0 and upper, mount() require data_len as a fifth argument.

Patch Set 1 #

Patch Set 2 : diff -r d6bcd9992cb6 https://code.google.com/p/plan9port/ #

Patch Set 3 : diff -r d6bcd9992cb6 https://code.google.com/p/plan9port/ #

Patch Set 4 : diff -r 78b8c2d0a598 https://code.google.com/p/plan9port/ #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/cmd/vbackup/mount-BSD.c	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

0intro

Hello rsc (cc: elbingmiss@gmail.com), I'd like you to review this change to https://code.google.com/p/plan9port/

9 years, 9 months ago (2014-07-23 18:48:42 UTC) #1

0intro

9 years, 8 months ago (2014-08-06 12:44:00 UTC) #3

*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=569143f2aa4e ***

vbackup: fix compilation on NetBSD (thanks Álvaro Jurado)

On NetBSD 5.0 and upper, mount() require
data_len as a fifth argument.

LGTM=rsc
R=rsc
CC=elbingmiss
https://codereview.appspot.com/111600043

Expand All Messages | Collapse All Messages