Issue 11143043: code review 11143043: cmd/ld: correct assignment of sizes to mach-o symbols

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11143043: code review 11143043: cmd/ld: correct assignment of sizes to mach-o symbols (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 12 months ago by rsc

Modified:
11 years, 12 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

cmd/ld: correct assignment of sizes to mach-o symbols If you compute the size by subtraction from the address of the next symbol, it helps to wait until the symbols have been sorted by address.

Patch Set 1 #

Patch Set 2 : diff -r 79764384421c https://code.google.com/p/go/ #

Patch Set 3 : diff -r 79764384421c https://code.google.com/p/go/ #

Patch Set 4 : diff -r ddb4f9feee8b https://code.google.com/p/go/ #

Created: 11 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -9 lines)			Patch
	M	src/cmd/ld/ldmacho.c	View	1	3 chunks	+14 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 12 months ago (2013-07-11 01:34:50 UTC) #1

rsc

11 years, 12 months ago (2013-07-11 02:06:56 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=58e3a3c29b9e ***

cmd/ld: correct assignment of sizes to mach-o symbols

If you compute the size by subtraction from the address
of the next symbol, it helps to wait until the symbols have
been sorted by address.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/11143043

Expand All Messages | Collapse All Messages