Issue 111410043: Now only tags specific to ticket items are shown in +tickets view and suggested_tags in modify view…

Issue 111410043: Now only tags specific to ticket items are shown in +tickets view and suggested_tags in modify view… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by sksaurabhkathpalia

Modified:
9 years, 8 months ago

Reviewers:
thomas.j.waldmann, dimazest

Visibility:
Public.

More Reviews

Description

Now only tags specific to ticket items are shown in +tickets view and suggested_tags in modify view…

Patch Set 2 : Removed inner for loop and also removed changes in css files(will do those changes in a separate pa… #

Patch Set 3 : Added function for extracting itemtype specific tags #

Total comments: 1

Patch Set 4 : Added doc string in the function #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -16 lines)			Patch
M	MoinMoin/apps/frontend/views.py	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	MoinMoin/items/__init__.py	View	1 2 3	2 chunks	+13 lines, -1 line	0 comments	Download
M	MoinMoin/items/ticket.py	View	1 2	2 chunks	+12 lines, -13 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dimazest

https://codereview.appspot.com/111410043/diff/1/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): https://codereview.appspot.com/111410043/diff/1/MoinMoin/apps/frontend/views.py#newcode2301 MoinMoin/apps/frontend/views.py:2301: tickets = searcher.search(Term(ITEMTYPE, ITEMTYPE_TICKET), limit=None) i'm not sure that ...

9 years, 9 months ago (2014-07-21 16:02:01 UTC) #1

Thomas.J.Waldmann

https://codereview.appspot.com/111410043/diff/1/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): https://codereview.appspot.com/111410043/diff/1/MoinMoin/apps/frontend/views.py#newcode2305 MoinMoin/apps/frontend/views.py:2305: tags.add(tag) you don't need that inner for loop. just ...

9 years, 8 months ago (2014-08-04 18:10:25 UTC) #2

sksaurabhkathpalia

https://codereview.appspot.com/111410043/diff/1/MoinMoin/themes/basic/static/css/basic.css File MoinMoin/themes/basic/static/css/basic.css (left): https://codereview.appspot.com/111410043/diff/1/MoinMoin/themes/basic/static/css/basic.css#oldcode6945 MoinMoin/themes/basic/static/css/basic.css:6945: padding-left: 20px; On 2014/08/04 18:10:25, Thomas.J.Waldmann wrote: > is ...

9 years, 8 months ago (2014-08-04 18:18:43 UTC) #3

Thomas.J.Waldmann

ok, looks fine now except that you should remove the code duplication.

9 years, 8 months ago (2014-08-09 16:51:39 UTC) #4

Thomas.J.Waldmann

9 years, 8 months ago (2014-08-09 17:01:50 UTC) #5

https://codereview.appspot.com/111410043/diff/40001/MoinMoin/items/__init__.py
File MoinMoin/items/__init__.py (right):

https://codereview.appspot.com/111410043/diff/40001/MoinMoin/items/__init__.p...
MoinMoin/items/__init__.py:270: def get_itemtype_specific_tags(itemtype):
add a docstring please

Expand All Messages | Collapse All Messages