Admin traceback emails

Create the ability for admins to receive emails when an exception happens, by
getting provided with admin emails.
Make a custom logging handler that wraps around the moin function sendmail().

The commits: https://bitbucket.org/ana-balica/moin-2.0/commits/2e7e81a3133fd63674f1a39122f85f4051d197e4
and
https://bitbucket.org/ana-balica/moin-2.0/commits/9ea845c1c826f9613b10a3964d044c57e3befda6

[Thomas.J.Waldmann, 2013-07-12 23:13:09]

https://codereview.appspot.com/11139044/diff/1/MoinMoin/log.py
File MoinMoin/log.py (right):

https://codereview.appspot.com/11139044/diff/1/MoinMoin/log.py#newcode208
MoinMoin/log.py:208: subject = self.subject if self.subject else '[{0}]
Traceback reported'.format(cfg.sitename)
you can't really assume it is a traceback, right?
it could be anything that is logged in a way so that this handler gets it.

[ana.balica, 2013-07-13 20:45:45]

https://codereview.appspot.com/11139044/diff/1/MoinMoin/log.py
File MoinMoin/log.py (right):

https://codereview.appspot.com/11139044/diff/1/MoinMoin/log.py#newcode208
MoinMoin/log.py:208: subject = self.subject if self.subject else '[{0}]
Traceback reported'.format(cfg.sitename)
On 2013/07/12 23:13:09, Thomas.J.Waldmann wrote:
> you can't really assume it is a traceback, right?
> it could be anything that is logged in a way so that this handler gets it.

Yes, anything. 
By having log level == error, the handler will catch also logging.error()
anywhere, so a traceback is not guaranteed.
Maybe "EmailHandler logging message reported"?

[Thomas.J.Waldmann, 2013-07-13 22:28:48]

https://codereview.appspot.com/11139044/diff/1/MoinMoin/log.py
File MoinMoin/log.py (right):

https://codereview.appspot.com/11139044/diff/1/MoinMoin/log.py#newcode208
MoinMoin/log.py:208: subject = self.subject if self.subject else '[{0}]
Traceback reported'.format(cfg.sitename)

> Maybe "EmailHandler logging message reported"?

<sitename> <loglevel> log message

if you can you access the log level somehow.

[Thomas.J.Waldmann, 2013-07-14 10:25:05]

https://codereview.appspot.com/11139044/diff/7001/MoinMoin/log.py
File MoinMoin/log.py (right):

https://codereview.appspot.com/11139044/diff/7001/MoinMoin/log.py#newcode209
MoinMoin/log.py:209: return cp.get(section_name, 'level')
ehrm, is there no easier way than parsing it from the config?

maybe the handler has some access to it via some attribute?

[Thomas.J.Waldmann, 2013-07-16 16:21:01]

https://codereview.appspot.com/11139044/diff/11001/MoinMoin/log.py
File MoinMoin/log.py (right):

https://codereview.appspot.com/11139044/diff/11001/MoinMoin/log.py#newcode208
MoinMoin/log.py:208: log_level = logging.getLevelName(self.level)
looks better now :D

[ana.balica, 2013-07-16 19:09:27]

The patch is commited and pushed.
I am closing this issue to not "pollute" the cr environment.

If any other suggestions will appear, we can comment directly on bitbucket.