Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(493)

Issue 111350043: code review 111350043: runtime: add Benchmark[Clear|Copy]Fat[16|24] (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by josharian
Modified:
10 years, 8 months ago
Reviewers:
khr1
CC:
golang-codereviews, khr, khr1
Visibility:
Public.

Description

runtime: add Benchmark[Clear|Copy]Fat[16|24] These benchmarks are important for performance. When compiling the stdlib: * 77.1% of the calls to sgen (copyfat) are for 16 bytes; another 8.7% are for 24 bytes. (The next most common is 32 bytes, at 5.7%.) * Over half the calls to clearfat are for 16 or 24 bytes.

Patch Set 1 #

Patch Set 2 : diff -r d09fd7725f9b https://code.google.com/p/go #

Patch Set 3 : diff -r d09fd7725f9b https://code.google.com/p/go #

Patch Set 4 : diff -r d09fd7725f9b https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M src/pkg/runtime/memmove_test.go View 1 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 6
josharian
Hello golang-codereviews@googlegroups.com (cc: khr@golang.org), I'd like you to review this change to https://code.google.com/p/go
10 years, 8 months ago (2014-07-18 18:25:55 UTC) #1
josharian
I have follow-up CLs that improve these benchmarks. I will mail them, and other related ...
10 years, 8 months ago (2014-07-18 18:27:19 UTC) #2
khr
On 2014/07/18 18:27:19, josharian wrote: > I have follow-up CLs that improve these benchmarks. I ...
10 years, 8 months ago (2014-07-18 18:55:23 UTC) #3
josharian
On 2014/07/18 18:55:23, khr wrote: > On 2014/07/18 18:27:19, josharian wrote: > > I have ...
10 years, 8 months ago (2014-07-18 19:11:36 UTC) #4
khr1
Maybe there was an issue with alignment testing that precluded faster copies on arm for ...
10 years, 8 months ago (2014-07-18 19:17:12 UTC) #5
josharian
10 years, 8 months ago (2014-07-18 19:18:40 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=696aba5c3fff ***

runtime: add Benchmark[Clear|Copy]Fat[16|24]

These benchmarks are important for performance. When compiling the stdlib:

* 77.1% of the calls to sgen (copyfat) are for 16 bytes; another 8.7% are for 24
bytes. (The next most common is 32 bytes, at 5.7%.)
* Over half the calls to clearfat are for 16 or 24 bytes.

LGTM=khr
R=golang-codereviews, khr
CC=golang-codereviews
https://codereview.appspot.com/111350043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b