Issue 111320044: code review 111320044: sync/atomic: fix data races in tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 111320044: code review 111320044: sync/atomic: fix data races in tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by dvyukov

Modified:
10 years, 5 months ago

Reviewers:
r, gobot

CC:
golang-codereviews, r

Visibility:
Public.

sync/atomic: fix data races in tests Fixes issue 8389.

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	src/pkg/sync/atomic/atomic_test.go	View		8 chunks	+8 lines, -8 lines	0 comments	Download

Total messages: 4

dvyukov

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

10 years, 5 months ago (2014-07-18 14:52:28 UTC) #1

dvyukov

*** Submitted as https://code.google.com/p/go/source/detail?r=c29c82b55ac0 *** sync/atomic: fix data races in tests Fixes issue 8389. LGTM=r ...

10 years, 5 months ago (2014-07-20 10:59:26 UTC) #3

gobot

10 years, 5 months ago (2014-07-20 11:22:14 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the linux-arm-cheney-panda builder.
See http://build.golang.org/log/62bdd2894ed6876d2e46e38ce2f3e00f1af9bd85