code review 111310044: runtime/race: better handling of atomic operations

runtime/race: better handling of atomic operations
This change fixes the last known false negative of the race detector --
detection of races between mutating atomic operations and non-atomic operations.
Race runtime already has functions for precise modelling of various atomic operations,
so this change just forwards all atomic ops to race runtime
instead of poor man modeling in sync/atomic package.
Performance is also improved -- full sync/atomic tests run in 60s instead of 85s now.

[dvyukov, 2014-07-18 16:02:13]

Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rsc@golang.org),

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[dvyukov, 2014-07-18 16:03:01]

I will upload the rest of the syso's later.

[khr, 2014-07-18 22:51:27]

LGTM.

[dvyukov, 2014-09-01 12:04:54]

*** Submitted as https://code.google.com/p/go/source/detail?r=4085766e8390 ***

runtime/race: better handling of atomic operations
This change fixes the last known false negative of the race detector --
detection of races between mutating atomic operations and non-atomic operations.
Race runtime already has functions for precise modelling of various atomic
operations,
so this change just forwards all atomic ops to race runtime
instead of poor man modeling in sync/atomic package.
Performance is also improved -- full sync/atomic tests run in 60s instead of 85s
now.

LGTM=khr
R=golang-codereviews, khr
CC=golang-codereviews, rsc
https://codereview.appspot.com/111310044

[gobot, 2014-09-01 12:07:07]

This CL appears to have broken the darwin-386-cheney builder.
See http://build.golang.org/log/14818d6bb26c89b527361ccde687e1f2151125c5

[dave_cheney.net, 2014-09-01 12:18:49]

More worrying network errors

ok   mime/multipart 0.482s
--- FAIL: TestDialMultiFDLeak (0.43s)
dial_test.go:404: tcp sessions: 7, open sessions: 6, closing sessions: 1
dial_test.go:407: got 6 open sessions; expected 2
FAIL
FAIL net 3.041s
ok   net/http 9.396s

On Mon, Sep 1, 2014 at 10:07 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the darwin-386-cheney builder.
> See http://build.golang.org/log/14818d6bb26c89b527361ccde687e1f2151125c5
>
>
> https://codereview.appspot.com/111310044/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.