Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1632)

Issue 11124044: remove juju --version

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by jameinel
Modified:
10 years, 9 months ago
Reviewers:
gz, mp+174018, dimitern
Visibility:
Public.

Description

remove juju --version Turns out that you can't have a global arg with the same name as a local argument. And 'juju --version' is the same name as 'juju upgrade-juju --version'. So even though you don't use it, my patch to add a global '--version' causes juju to panic when you try to run 'juju upgrade-juju -h'. I don't have a great way to fix it in mind, so I'm just reverting the patch. https://code.launchpad.net/~jameinel/juju-core/revert--version/+merge/174018 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/main_test.go View 2 chunks +0 lines, -6 lines 0 comments Download
M cmd/supercommand.go View 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3
jameinel
Please take a look.
10 years, 9 months ago (2013-07-10 18:28:40 UTC) #1
gz
LGTM as backout, will need to reopen the bug and think of a way of ...
10 years, 9 months ago (2013-07-10 18:43:53 UTC) #2
dimitern
10 years, 9 months ago (2013-07-10 18:48:56 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b