Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(71)

Issue 111230044: code review 111230044: cmd/ld: use count, not upper bound, in type of array (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by r
Modified:
7 years, 4 months ago
Reviewers:
gobot, rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

cmd/ld: use count, not upper bound, in type of array DWARF says only one is necessary. The count is preferable because it admits 0-length arrays. Update debug/dwarf to handle either form.

Patch Set 1 #

Patch Set 2 : diff -r 9562b65a3c51 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M src/cmd/ld/dwarf.c View 4 chunks +5 lines, -4 lines 0 comments Download
M src/pkg/debug/dwarf/type.go View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 5
r
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
7 years, 4 months ago (2014-07-16 18:04:10 UTC) #1
rsc
LGTM If clang/gcc write these out it would fix some long-standing bugs in cgo. Not ...
7 years, 4 months ago (2014-07-16 18:20:52 UTC) #2
r
*** Submitted as https://code.google.com/p/go/source/detail?r=b347db31aa87 *** cmd/ld: use count, not upper bound, in type of array ...
7 years, 4 months ago (2014-07-16 18:26:53 UTC) #3
gobot
This CL appears to have broken the linux-arm-cheney-panda builder. See http://build.golang.org/log/66a0a61034c9cd24b707adcfd204a17d20ddbdf7
7 years, 4 months ago (2014-07-16 18:45:31 UTC) #4
rsc
7 years, 4 months ago (2014-07-16 18:51:36 UTC) #5
Seems unlikely. A cgo failure I could understand.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b