Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(99)

Issue 111130045: code review 111130045: runtime: zero dangling pointer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by dvyukov
Modified:
10 years, 8 months ago
Reviewers:
gobot, khr
CC:
golang-codereviews, khr, rsc
Visibility:
Public.

Description

runtime: zero dangling pointer I don't see how it can lead to bad things today. But it's better to kill it before it does.

Patch Set 1 #

Patch Set 2 : diff -r 67f9ef140028 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 67f9ef140028 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 67f9ef140028 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 5207b394de96 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/pkg/runtime/chan.goc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dvyukov
Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 8 months ago (2014-07-14 11:44:12 UTC) #1
khr
On 2014/07/14 11:44:12, dvyukov wrote: > Hello mailto:golang-codereviews@googlegroups.com (cc: mailto:khr@golang.org, mailto:rsc@golang.org), > > I'd like ...
10 years, 8 months ago (2014-07-14 23:29:55 UTC) #2
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=4bcccdc31eeb *** runtime: zero dangling pointer I don't see how it can ...
10 years, 8 months ago (2014-07-15 06:29:27 UTC) #3
gobot
10 years, 8 months ago (2014-07-15 06:51:02 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/0279a931d27436e1b297fb3ef36b48f4f440272b
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b