Implement the service constraints viewlet.

Implement the service constraints viewlet.

For now the viewlet can be displayed clicking "C"
in the inspector.
Implemented constraints update, conflict resolution
and data-binding.

Also fixed a bug in databinding.js: 
fixed the context of resolve().

https://code.launchpad.net/~frankban/juju-gui/inspector-constraints/+merge/173941

(do not edit description out of merge proposal)

[frankban, 2013-07-10 13:25:15]

Please take a look.

[frankban, 2013-07-10 13:27:49]

Please take a look.

[jeff.pihach, 2013-07-10 15:28:59]

This looks great thanks! LGTM

I would like to confirm that you knew that the constraints were supposed to be
part of the settings page. You should create a follow-up card to move it once
the scrolling story has been implemented.

If you could also merge the changes in trunk in and then QA first that would be
awesome.

https://codereview.appspot.com/11110043/diff/12001/app/views/databinding.js
File app/views/databinding.js (right):

https://codereview.appspot.com/11110043/diff/12001/app/views/databinding.js#n...
app/views/databinding.js:500: Y.bind(resolve, self));
There were extensive changes to the databinding class which landed yesterday -
does this include those changes? If not you should merge trunk in to test to
make sure everything works properly still.

https://codereview.appspot.com/11110043/diff/12001/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/11110043/diff/12001/app/views/environment.js#n...
app/views/environment.js:191: viewletList: ['overview', 'units', 'config',
'constraints'],
the mockups have constraints as part of the config view at the bottom not as
it's own viewlet - I'm assuming you did this because the scrolling story hasn't
been implemented yet but can you confirm?

https://codereview.appspot.com/11110043/diff/12001/app/views/service.js
File app/views/service.js (right):

https://codereview.appspot.com/11110043/diff/12001/app/views/service.js#newco...
app/views/service.js:1475: _getConstraints: function(serviceConstraints,
genericConstraints) {
This looks to me to be a utility method not part of the actual viewlet so I
would like to see it moved into one of the, or a new, prototype method
collections.

[bac, 2013-07-10 15:42:17]

The code changes look good.  Doing QA I found some oddities.

When first seen (for glance) the constraints were ordered CPU, Memory,
Architecture.  After changing one value (memory) and closing the inspector,
re-opening showed the changed value first (Memory, CPU, Architecture). 
Repeating showed that the changed field always gets displayed first on
subsequent openings.

Also, setting a value and later trying to clear it out gave the conflict
warning, which is unexpected.

https://codereview.appspot.com/11110043/diff/12001/app/templates/service-cons...
File app/templates/service-constraints-viewlet.handlebars (right):

https://codereview.appspot.com/11110043/diff/12001/app/templates/service-cons...
app/templates/service-constraints-viewlet.handlebars:4: <!-- XXX Perhaps the
following will be moved to the container template. -->
Please sign your XXX.

https://codereview.appspot.com/11110043/diff/12001/app/views/service.js
File app/views/service.js (right):

https://codereview.appspot.com/11110043/diff/12001/app/views/service.js#newco...
app/views/service.js:1467: @param {Object} serviceConstraints A key-value pairs
representing
s/A key-value/Key-value/

[frankban, 2013-07-11 15:07:44]

Please take a look.

https://codereview.appspot.com/11110043/diff/12001/app/templates/service-cons...
File app/templates/service-constraints-viewlet.handlebars (right):

https://codereview.appspot.com/11110043/diff/12001/app/templates/service-cons...
app/templates/service-constraints-viewlet.handlebars:4: <!-- XXX Perhaps the
following will be moved to the container template. -->
On 2013/07/10 15:42:17, bac wrote:
> Please sign your XXX.

Done.

https://codereview.appspot.com/11110043/diff/12001/app/views/databinding.js
File app/views/databinding.js (right):

https://codereview.appspot.com/11110043/diff/12001/app/views/databinding.js#n...
app/views/databinding.js:500: Y.bind(resolve, self));
On 2013/07/10 15:29:00, jeff.pihach wrote:
> There were extensive changes to the databinding class which landed yesterday -
> does this include those changes? If not you should merge trunk in to test to
> make sure everything works properly still.

The proposed branch already includes those changes.

https://codereview.appspot.com/11110043/diff/12001/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/11110043/diff/12001/app/views/environment.js#n...
app/views/environment.js:191: viewletList: ['overview', 'units', 'config',
'constraints'],
On 2013/07/10 15:29:00, jeff.pihach wrote:
> the mockups have constraints as part of the config view at the bottom not as
> it's own viewlet - I'm assuming you did this because the scrolling story
hasn't
> been implemented yet but can you confirm?

Indeed.

https://codereview.appspot.com/11110043/diff/12001/app/views/service.js
File app/views/service.js (right):

https://codereview.appspot.com/11110043/diff/12001/app/views/service.js#newco...
app/views/service.js:1467: @param {Object} serviceConstraints A key-value pairs
representing
On 2013/07/10 15:42:17, bac wrote:
> s/A key-value/Key-value/

Done.

https://codereview.appspot.com/11110043/diff/12001/app/views/service.js#newco...
app/views/service.js:1475: _getConstraints: function(serviceConstraints,
genericConstraints) {
On 2013/07/10 15:29:00, jeff.pihach wrote:
> This looks to me to be a utility method not part of the actual viewlet so I
> would like to see it moved into one of the, or a new, prototype method
> collections.

Good idea! Done and added tests.

[bac, 2013-07-11 15:30:40]

LGTM, thanks

https://codereview.appspot.com/11110043/diff/19001/app/views/databinding.js
File app/views/databinding.js (right):

https://codereview.appspot.com/11110043/diff/19001/app/views/databinding.js#n...
app/views/databinding.js:558: defined values with the users values.
typo: user's

[frankban, 2013-07-11 15:38:44]

*** Submitted:

Implement the service constraints viewlet.

For now the viewlet can be displayed clicking "C"
in the inspector.
Implemented constraints update, conflict resolution
and data-binding.

Also fixed a bug in databinding.js: 
fixed the context of resolve().

R=jeff.pihach, bac
CC=
https://codereview.appspot.com/11110043

https://codereview.appspot.com/11110043/diff/19001/app/views/databinding.js
File app/views/databinding.js (right):

https://codereview.appspot.com/11110043/diff/19001/app/views/databinding.js#n...
app/views/databinding.js:558: defined values with the users values.
On 2013/07/11 15:30:41, bac wrote:
> typo: user's

Done.