Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6505)

Issue 11105043: juju --version: support alternative syntax

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by jameinel
Modified:
10 years, 9 months ago
Reviewers:
mue, gz, mp+173893
Visibility:
Public.

Description

juju --version: support alternative syntax This makes it so the go version of juju supports the same flag as the python version. Namely "juju --version" prints out the version, as though you specified "juju version". This should be sufficient to close bug #1182898. There are some edge cases that I didn't try to solve (what is "juju init --version" supposed to do, etc.) Technically '--version' has to come before the command in order to be interpreted as a global option. For now the flag is just ignored, as the case we care about is plain 'juju --version' which works as expected. https://code.launchpad.net/~jameinel/juju-core/juju-version-1182898/+merge/173893 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/main_test.go View 2 chunks +6 lines, -0 lines 0 comments Download
M cmd/supercommand.go View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4
jameinel
Please take a look.
10 years, 9 months ago (2013-07-10 09:41:45 UTC) #1
gz
LGTM. Wondered if we wanted -V as well, but bzr doesn't use this and obviously ...
10 years, 9 months ago (2013-07-10 12:04:12 UTC) #2
jameinel
On 2013/07/10 12:04:12, gz wrote: > LGTM. Wondered if we wanted -V as well, but ...
10 years, 9 months ago (2013-07-10 12:18:56 UTC) #3
mue
10 years, 9 months ago (2013-07-10 14:04:07 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b