Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(441)

Issue 111050043: code review 111050043: go.talks: add "Go for Javaneros" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by francesc
Modified:
6 years, 6 months ago
Reviewers:
campoy, u, adg
CC:
adg, jacek.masiulaniec_gmail.com, kortschak, ioe, jscrockett01, golang-codereviews
Visibility:
Public.

Description

go.talks: add "Go for Javaneros"

Patch Set 1 #

Patch Set 2 : diff -r c636a8a8316f https://code.google.com/p/go.talks #

Patch Set 3 : diff -r c636a8a8316f https://code.google.com/p/go.talks #

Patch Set 4 : diff -r c636a8a8316f https://code.google.com/p/go.talks #

Patch Set 5 : diff -r c636a8a8316f https://code.google.com/p/go.talks #

Total comments: 4

Patch Set 6 : diff -r c636a8a8316f https://code.google.com/p/go.talks #

Patch Set 7 : diff -r c636a8a8316f https://code.google.com/p/go.talks #

Patch Set 8 : diff -r c636a8a8316f https://code.google.com/p/go.talks #

Patch Set 9 : diff -r c636a8a8316f https://code.google.com/p/go.talks #

Total comments: 6

Patch Set 10 : diff -r c636a8a8316f https://code.google.com/p/go.talks #

Patch Set 11 : diff -r c636a8a8316f https://code.google.com/p/go.talks #

Total comments: 8

Patch Set 12 : diff -r c636a8a8316f https://code.google.com/p/go.talks #

Patch Set 13 : diff -r c636a8a8316f https://code.google.com/p/go.talks #

Patch Set 14 : diff -r f10c43fe60f9 https://code.google.com/p/go.talks #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+1142 lines, -0 lines) Patch
A 2014/go4java.slide View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +667 lines, -0 lines 2 comments Download
A 2014/go4java/BadInheritance.java View 1 12 13 1 chunk +82 lines, -0 lines 0 comments Download
A 2014/go4java/Composition.java View 1 12 13 1 chunk +86 lines, -0 lines 0 comments Download
A 2014/go4java/battle.go View 1 12 13 1 chunk +22 lines, -0 lines 0 comments Download
A 2014/go4java/chan.go View 1 2 3 4 5 6 7 8 9 12 13 1 chunk +24 lines, -0 lines 0 comments Download
A 2014/go4java/conc1.go View 1 12 13 1 chunk +18 lines, -0 lines 0 comments Download
A 2014/go4java/conc2.go View 1 12 13 1 chunk +18 lines, -0 lines 0 comments Download
A 2014/go4java/conc3.go View 1 12 13 1 chunk +19 lines, -0 lines 0 comments Download
A 2014/go4java/embedsample.go View 1 12 13 1 chunk +20 lines, -0 lines 0 comments Download
A 2014/go4java/goodcounter.go View 1 12 13 1 chunk +22 lines, -0 lines 0 comments Download
A 2014/go4java/goroutines.go View 1 12 13 1 chunk +28 lines, -0 lines 0 comments Download
A 2014/go4java/img/baby.jpg View 1 12 13 Binary file 0 comments Download
A 2014/go4java/img/badinheritance.png View 1 12 13 Binary file 0 comments Download
A 2014/go4java/img/busy.jpg View 1 12 13 Binary file 0 comments Download
A 2014/go4java/img/chain.jpg View 1 12 13 Binary file 0 comments Download
A 2014/go4java/img/conc.jpg View 1 12 13 Binary file 0 comments Download
A 2014/go4java/img/duck.jpg View 1 12 13 Binary file 0 comments Download
A 2014/go4java/img/fast.jpg View 1 12 13 Binary file 0 comments Download
A 2014/go4java/img/funcdraw.png View 1 12 13 Binary file 0 comments Download
A 2014/go4java/img/funnelin.jpg View 1 12 13 Binary file 0 comments Download
A 2014/go4java/img/gopher.jpg View 1 12 13 Binary file 0 comments Download
A 2014/go4java/img/lego.jpg View 1 2 3 4 5 6 7 8 9 10 11 12 13 Binary file 0 comments Download
A 2014/go4java/img/perfection.jpg View 1 12 13 Binary file 0 comments Download
A 2014/go4java/img/piet.png View 1 12 13 Binary file 0 comments Download
A 2014/go4java/img/trends.png View 1 2 3 4 5 6 7 8 9 10 11 12 13 Binary file 0 comments Download
A 2014/go4java/loopback.go View 1 12 13 1 chunk +23 lines, -0 lines 0 comments Download
A 2014/go4java/runner/embed.go View 1 12 13 1 chunk +25 lines, -0 lines 0 comments Download
A 2014/go4java/runner/runner.go View 1 12 13 1 chunk +55 lines, -0 lines 0 comments Download
A 2014/go4java/writecounter.go View 1 12 13 1 chunk +33 lines, -0 lines 2 comments Download

Messages

Total messages: 20
francesc
Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks
6 years, 6 months ago (2014-07-10 18:31:39 UTC) #1
jacekm
https://codereview.appspot.com/111050043/diff/70001/2014/go4java.slide File 2014/go4java.slide (right): https://codereview.appspot.com/111050043/diff/70001/2014/go4java.slide#newcode215 2014/go4java.slide:215: Use `*` to redeference the pointer. dereference https://codereview.appspot.com/111050043/diff/70001/2014/go4java.slide#newcode238 2014/go4java.slide:238: ...
6 years, 6 months ago (2014-07-10 19:49:24 UTC) #2
campoy
Done, thanks! https://codereview.appspot.com/111050043/diff/70001/2014/go4java.slide File 2014/go4java.slide (right): https://codereview.appspot.com/111050043/diff/70001/2014/go4java.slide#newcode215 2014/go4java.slide:215: Use `*` to redeference the pointer. On ...
6 years, 6 months ago (2014-07-10 21:11:23 UTC) #3
campoy
Done, thanks!
6 years, 6 months ago (2014-07-10 21:11:28 UTC) #4
kortschak
I'm getting "patch did not apply cleanly" with hg clpatch.
6 years, 6 months ago (2014-07-11 00:46:35 UTC) #5
campoy
That might be a local problem. You can view the current version here too: http://go-talks.appspot.com/github.com/campoy/go4java/go4java.slide#1 ...
6 years, 6 months ago (2014-07-11 01:56:46 UTC) #6
kortschak
On 2014/07/11 01:56:46, campoy wrote: > That might be a local problem. > You can ...
6 years, 6 months ago (2014-07-11 02:23:54 UTC) #7
ioe
Great presentation, BTW! Just a few inconsistencies between slides and examples. https://codereview.appspot.com/111050043/diff/130001/2014/go4java.slide File 2014/go4java.slide (right): ...
6 years, 6 months ago (2014-07-11 07:13:05 UTC) #8
jscrockett01
CSP acronym https://codereview.appspot.com/111050043/diff/130001/2014/go4java.slide File 2014/go4java.slide (right): https://codereview.appspot.com/111050043/diff/130001/2014/go4java.slide#newcode72 2014/go4java.slide:72: Concurrent Sequential Processes - Hoare (1978) Communicating ...
6 years, 6 months ago (2014-07-11 13:11:29 UTC) #9
campoy
Thanks! https://codereview.appspot.com/111050043/diff/130001/2014/go4java.slide File 2014/go4java.slide (right): https://codereview.appspot.com/111050043/diff/130001/2014/go4java.slide#newcode72 2014/go4java.slide:72: Concurrent Sequential Processes - Hoare (1978) On 2014/07/11 ...
6 years, 6 months ago (2014-07-11 18:30:06 UTC) #10
adg
https://codereview.appspot.com/111050043/diff/170001/2014/go4java.slide File 2014/go4java.slide (right): https://codereview.appspot.com/111050043/diff/170001/2014/go4java.slide#newcode23 2014/go4java.slide:23: - YouTube (no gophers, no kittens!) what does this ...
6 years, 6 months ago (2014-07-14 06:44:54 UTC) #11
campoy
Thanks! PTAL, this now depends on https://codereview.appspot.com/110600043/ Captions look huge and appear to be more ...
6 years, 6 months ago (2014-07-14 18:46:49 UTC) #12
adg
On 15 July 2014 04:46, <campoy@google.com> wrote: > I'm using the naming from the specs: ...
6 years, 6 months ago (2014-07-15 00:34:33 UTC) #13
adg
LGTM
6 years, 6 months ago (2014-07-15 00:34:53 UTC) #14
adg
On 15 July 2014 04:46, <campoy@google.com> wrote: > PTAL, this now depends on https://codereview.appspot.com/110600043/ > ...
6 years, 6 months ago (2014-07-15 00:34:59 UTC) #15
campoy
ooops, done now On Mon, Jul 14, 2014 at 5:34 PM, Andrew Gerrand <adg@golang.org> wrote: ...
6 years, 6 months ago (2014-07-15 03:33:24 UTC) #16
francesc
*** Submitted as https://code.google.com/p/go/source/detail?r=ffc31a3242b5&repo=talks *** go.talks: add "Go for Javaneros" LGTM=adg R=adg, jacek.masiulaniec, campoy, dan.kortschak, ...
6 years, 6 months ago (2014-07-15 21:58:17 UTC) #17
u
useulf should be useful https://codereview.appspot.com/111050043/diff/210001/2014/go4java.slide File 2014/go4java.slide (right): https://codereview.appspot.com/111050043/diff/210001/2014/go4java.slide#newcode262 2014/go4java.slide:262: Method calls on nil receivers ...
6 years, 6 months ago (2014-07-16 11:42:04 UTC) #18
u
Update comment to reflect code. https://codereview.appspot.com/111050043/diff/210001/2014/go4java/writecounter.go File 2014/go4java/writecounter.go (right): https://codereview.appspot.com/111050043/diff/210001/2014/go4java/writecounter.go#newcode15 2014/go4java/writecounter.go:15: // WriteCounter counts how ...
6 years, 6 months ago (2014-07-16 11:51:47 UTC) #19
campoy
6 years, 6 months ago (2014-07-16 17:41:31 UTC) #20
Message was sent while issue was closed.
Done in https://codereview.appspot.com/112340043

https://codereview.appspot.com/111050043/diff/210001/2014/go4java.slide
File 2014/go4java.slide (right):

https://codereview.appspot.com/111050043/diff/210001/2014/go4java.slide#newco...
2014/go4java.slide:262: Method calls on nil receivers are perfectly valid (and
useulf!).
On 2014/07/16 11:42:04, u wrote:
> useulf should be useful.

Done.

https://codereview.appspot.com/111050043/diff/210001/2014/go4java/writecounte...
File 2014/go4java/writecounter.go (right):

https://codereview.appspot.com/111050043/diff/210001/2014/go4java/writecounte...
2014/go4java/writecounter.go:15: // WriteCounter counts how many times `Write`
is called
On 2014/07/16 11:51:47, u wrote:
> "counts how many times `Write` is called" should be replaced with "counts the
> number of bytes written through `Write`", or something along those lines.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b